Issue 1294213002: Remove SkOpts_sse2.cpp.

Issue 1294213002: Remove SkOpts_sse2.cpp. (Closed)

Created:
5 years, 4 months ago by mtklein_C

Modified:
5 years, 4 months ago

Reviewers:
djsollen, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Remove SkOpts_sse2.cpp. It's sort of pointless: all our clients that will have SSE2 at runtime have it unconditionally at compile time, so the functions in namespace portable will pick up the SSE2 code. The procs in SkOpts_sse2.o were just duplicate code. A couple of the procs we had in _sse2.cpp can benefit slightly when compiled with SSSE3. I've moved those to _ssse3.cpp. This should lead to small speedups on platforms like Linux and Windows that have a baseline of SSE2. Similarly, I've removed the call to Init_neon() when NEON is available globally... it's a no-op. Renaming namespace portable to something clearer is TBD. BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/948376379362e54c5357005778ba5f53f3dc9d5e

Patch Set 1 #

Patch Set 2 : update runtime detection #

Patch Set 3 : ns #

Patch Set 4 : char ~0 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -42 lines)			Patch
M	gyp/opts.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/core/SkOpts.cpp	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
D	src/opts/SkOpts_sse2.cpp	View		1 chunk	+0 lines, -34 lines	0 comments	Download
M	src/opts/SkOpts_ssse3.cpp	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/opts/SkPMFloat_sse.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download