Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 12942014: Move GrGLProgram::Desc out of GrGLProgram. (Closed)

Created:
7 years, 9 months ago by bsalomon
Modified:
7 years, 9 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Move GrGLProgram::Desc out of GrGLProgram. Committed: https://code.google.com/p/skia/source/detail?r=8411

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Move #include below dbl include check #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -201 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrTypesPriv.h View 1 2 2 chunks +32 lines, -0 lines 0 comments Download
M src/gpu/GrDrawState.h View 2 chunks +1 line, -30 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 6 chunks +5 lines, -102 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 20 chunks +50 lines, -57 lines 0 comments Download
A src/gpu/gl/GrGLProgramDesc.h View 1 2 3 1 chunk +104 lines, -0 lines 2 comments Download
M src/gpu/gl/GrGLVertexArray.h View 2 chunks +26 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
This is necessary to make the desc class declaration visible to GrGLShaderBuilder.h which I want ...
7 years, 9 months ago (2013-03-27 15:45:47 UTC) #1
robertphillips
lgtm + nit https://codereview.chromium.org/12942014/diff/7004/src/gpu/gl/GrGLProgramDesc.h File src/gpu/gl/GrGLProgramDesc.h (right): https://codereview.chromium.org/12942014/diff/7004/src/gpu/gl/GrGLProgramDesc.h#newcode36 src/gpu/gl/GrGLProgramDesc.h:36: void setRandom(SkMWCRandom*, spaces
7 years, 9 months ago (2013-03-27 18:07:10 UTC) #2
bsalomon
Committed patchset #4 manually as r8411 (presubmit successful).
7 years, 9 months ago (2013-03-27 18:15:07 UTC) #3
bsalomon
7 years, 9 months ago (2013-03-27 18:17:16 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/12942014/diff/7004/src/gpu/gl/GrGLProgramDesc.h
File src/gpu/gl/GrGLProgramDesc.h (right):

https://codereview.chromium.org/12942014/diff/7004/src/gpu/gl/GrGLProgramDesc...
src/gpu/gl/GrGLProgramDesc.h:36: void setRandom(SkMWCRandom*,
On 2013/03/27 18:07:10, robertphillips wrote:
> spaces

Done.

Powered by Google App Engine
This is Rietveld 408576698