Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 1294183002: DevTools: Tweak id calculation for JSFrames (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.VBox} 7 * @extends {WebInspector.VBox}
8 * @param {!WebInspector.TimelineModel} model 8 * @param {!WebInspector.TimelineModel} model
9 */ 9 */
10 WebInspector.TimelineTreeView = function(model) 10 WebInspector.TimelineTreeView = function(model)
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 }, 263 },
264 264
265 /** 265 /**
266 * @param {!WebInspector.TracingModel.Event} e 266 * @param {!WebInspector.TracingModel.Event} e
267 * @return {string} 267 * @return {string}
268 */ 268 */
269 _eventId: function(e) 269 _eventId: function(e)
270 { 270 {
271 if (e.name === WebInspector.TimelineModel.RecordType.JSFrame) { 271 if (e.name === WebInspector.TimelineModel.RecordType.JSFrame) {
272 var data = e.args["data"]; 272 var data = e.args["data"];
273 return "f:" + (data["callUID"] || WebInspector.TimelineTreeView.even tURL(e)); 273 return "f:" + data["functionName"] + "@" + (data["scriptId"] || data ["url"] || "");
yurys 2015/08/17 19:21:36 Can we have a test for this?
alph 2015/08/17 21:09:34 Done.
274 } 274 }
275 return e.name + ":@" + WebInspector.TimelineTreeView.eventURL(e); 275 return e.name + ":@" + WebInspector.TimelineTreeView.eventURL(e);
276 }, 276 },
277 277
278 __proto__: WebInspector.VBox.prototype 278 __proto__: WebInspector.VBox.prototype
279 } 279 }
280 280
281 /** 281 /**
282 * @param {!WebInspector.TracingModel.Event} event 282 * @param {!WebInspector.TracingModel.Event} event
283 * @return {?string} 283 * @return {?string}
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 if (!this._profileNode.children) 413 if (!this._profileNode.children)
414 return; 414 return;
415 for (var node of this._profileNode.children.values()) { 415 for (var node of this._profileNode.children.values()) {
416 var gridNode = new WebInspector.TimelineTreeView.GridNode(node, this ._totalTime); 416 var gridNode = new WebInspector.TimelineTreeView.GridNode(node, this ._totalTime);
417 this.insertChildOrdered(gridNode); 417 this.insertChildOrdered(gridNode);
418 } 418 }
419 }, 419 },
420 420
421 __proto__: WebInspector.SortableDataGridNode.prototype 421 __proto__: WebInspector.SortableDataGridNode.prototype
422 } 422 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698