Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: src/compiler/linkage.cc

Issue 1294133004: [Interpreter] Pass context to interpreter bytecode handlers and add LoadConstextSlot (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/linkage.h ('k') | src/compiler/raw-machine-assembler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/linkage.cc
diff --git a/src/compiler/linkage.cc b/src/compiler/linkage.cc
index 66e5cda7d7536f01431f1bdf9edf4a1b114299b0..3ef5b9a7a61ea337f6fcc417ec18c15fa5ffb788 100644
--- a/src/compiler/linkage.cc
+++ b/src/compiler/linkage.cc
@@ -387,8 +387,8 @@ CallDescriptor* Linkage::GetJSCallDescriptor(Zone* zone, bool is_osr,
CallDescriptor* Linkage::GetInterpreterDispatchDescriptor(Zone* zone) {
- MachineSignature::Builder types(zone, 0, 5);
- LocationSignature::Builder locations(zone, 0, 5);
+ MachineSignature::Builder types(zone, 0, 6);
+ LocationSignature::Builder locations(zone, 0, 6);
// Add registers for fixed parameters passed via interpreter dispatch.
STATIC_ASSERT(0 == Linkage::kInterpreterAccumulatorParameter);
@@ -411,6 +411,15 @@ CallDescriptor* Linkage::GetInterpreterDispatchDescriptor(Zone* zone) {
types.AddParam(kMachPtr);
locations.AddParam(regloc(kInterpreterDispatchTableRegister));
+ STATIC_ASSERT(5 == Linkage::kInterpreterContextParameter);
+ types.AddParam(kMachAnyTagged);
+#if defined(V8_TARGET_ARCH_IA32)
Michael Starzinger 2015/08/20 09:32:02 Just for posterity: Not a huge fan of this #ifdef
rmcilroy 2015/08/24 10:14:38 Acknowledged.
+ locations.AddParam(
+ LinkageLocation::ForCallerFrameSlot(kInterpreterContextSpillSlot));
+#else
+ locations.AddParam(regloc(kContextRegister));
+#endif
+
LinkageLocation target_loc = LinkageLocation::ForAnyRegister();
return new (zone) CallDescriptor( // --
CallDescriptor::kCallCodeObject, // kind
« no previous file with comments | « src/compiler/linkage.h ('k') | src/compiler/raw-machine-assembler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698