[Presentation API, MediaRouter] Routing from media sink selection to route creation.

chrome/browser/media/router/media_router_dialog_controller.h

Index: chrome/browser/media/router/media_router_dialog_controller.h
diff --git a/chrome/browser/media/router/media_router_dialog_controller.h b/chrome/browser/media/router/media_router_dialog_controller.h
index 86e3620a5bc970d644939d8ce675d792e2847af8..ef5caf3168fc5628f5a7ff2e26c4e286a65e4d25 100644
--- a/chrome/browser/media/router/media_router_dialog_controller.h
+++ b/chrome/browser/media/router/media_router_dialog_controller.h
@@ -5,6 +5,8 @@
 #ifndef CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_DIALOG_CONTROLLER_H_
 #define CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_DIALOG_CONTROLLER_H_
 
+#include <string>
+
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/threading/thread_checker.h"
@@ -54,10 +56,17 @@ class MediaRouterDialogController {
   // instance.
   explicit MediaRouterDialogController(content::WebContents* initiator);
 
+  // Activates the WebContents that initiated the dialog, e.g. focuses the tab.
   void ActivateInitiatorWebContents();
 
+  // Passes the ownership of the CreatePresentationSessionRequest to the caller.
   scoped_ptr<CreatePresentationSessionRequest> PassPresentationRequest();

[Wez, 2015/08/18 21:50:09]

nit: "take" seems to be the more common/logical terminology here, since you're
not passing the MediaRouteDialogController, but taking the
PresentationSessionRequest from it.  Up to you, though.

[whywhat, 2015/08/19 13:04:29]

Ack. Will change in a separate code review perhaps :)

 
+  // Returns the CreatePresentationSessionRequest to the caller but keeps the
+  // ownership with the MediaRouterDialogController.
+  CreatePresentationSessionRequest* GetPresentationRequest();

[Wez, 2015/08/18 21:50:09]

Should the request be const, then? And similarly should the getter be a const
method?

Since this is a simple getter, its implementation should be in-line, and it
should be called presentation_request(), similarly to initiator().

You only need it out-of-line to allow you to DCHECK; is that necessary, or could
you rely on callers DCHECKing, or dereferencing it and crashing?

[whywhat, 2015/08/19 13:04:29]

Done.

+
+  // Returns the WebContents that initiated showing the dialog.
   content::WebContents* initiator() const { return initiator_; }
 
   // Resets the state of the controller. Must be called from the overrides.