chrome/browser/media/router/create_presentation_session_request.h - Issue 1294133002: [Presentation API, MediaRouter] Routing from media sink selection to route creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/create_presentation_session_request.h

Issue 1294133002: [Presentation API, MediaRouter] Routing from media sink selection to route creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media-router-discovery-2

Patch Set: Added comments and DCHECKs for null presentation request Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/android/router/media_router_dialog_controller_android.cc ('K') | « chrome/browser/media/android/router/media_router_dialog_controller_android.cc ('k') | chrome/browser/media/router/create_presentation_session_request.cc » ('j') | chrome/browser/media/router/create_presentation_session_request.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/create_presentation_session_request.h

diff --git a/chrome/browser/media/router/create_presentation_session_request.h b/chrome/browser/media/router/create_presentation_session_request.h

index b7d6e5088c9f7260e62bd87ca2194d8baa3479bd..70f6b7d35bb8f2a579aa66a4e9efb4d1fdb225da 100644

--- a/chrome/browser/media/router/create_presentation_session_request.h

+++ b/chrome/browser/media/router/create_presentation_session_request.h

@@ -55,6 +55,13 @@ class CreatePresentationSessionRequest {

const MediaRoute::Id& route_id);

void MaybeInvokeErrorCallback(const content::PresentationError& error);

+ // Handle route creation/joining response by invoking the right callback.

+ static void HandleRouteResponse(

+ scoped_ptr<CreatePresentationSessionRequest> presentation_request,

+ const MediaRoute* route,

+ const std::string& presentation_id,

+ const std::string& error);

private:

const MediaSource media_source_;

const GURL frame_url_;