Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: chrome/browser/media/android/router/media_router_dialog_controller_android.cc

Issue 1294133002: [Presentation API, MediaRouter] Routing from media sink selection to route creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media-router-discovery-2
Patch Set: Report when the user dismisses the dialog. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/android/router/media_router_dialog_controller_android.cc
diff --git a/chrome/browser/media/android/router/media_router_dialog_controller_android.cc b/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
index fd034d45b91e87efacab5a45cd38b4698eb8b5e4..37604789cb55d7aca93c1b2afcadc1cf1229c09e 100644
--- a/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
+++ b/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
@@ -6,7 +6,11 @@
#include "base/android/jni_android.h"
#include "base/android/jni_string.h"
+#include "chrome/browser/media/android/router/media_router_android.h"
+#include "chrome/browser/media/router/media_router.h"
+#include "chrome/browser/media/router/media_router_factory.h"
#include "chrome/browser/media/router/media_source.h"
+#include "chrome/browser/sessions/session_tab_helper.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_delegate.h"
@@ -15,6 +19,7 @@
DEFINE_WEB_CONTENTS_USER_DATA_KEY(
media_router::MediaRouterDialogControllerAndroid);
+using base::android::ConvertJavaStringToUTF8;
using content::WebContents;
namespace media_router {
@@ -29,6 +34,43 @@ MediaRouterDialogControllerAndroid::GetOrCreateForWebContents(
return MediaRouterDialogControllerAndroid::FromWebContents(web_contents);
}
+void MediaRouterDialogControllerAndroid::OnSinkSelected(
+ JNIEnv* env, jobject obj, jstring jsink_id) {
+ scoped_ptr<CreatePresentationSessionRequest>
+ request(PassPresentationRequest());
imcheng 2015/08/18 17:50:34 Can |request| be null here? Is there a notion of
whywhat 2015/08/18 19:21:24 Nope, there's no notion of browser-initiated prese
+ const std::string& source_id = request->media_source().id();
+ const GURL& origin = request->frame_url().GetOrigin();
+
+ std::vector<MediaRouteResponseCallback> route_response_callbacks;
+ route_response_callbacks.push_back(
+ base::Bind(&CreatePresentationSessionRequest::HandleRouteResponse,
+ base::Passed(&request)));
+
+ MediaRouter* router = static_cast<MediaRouterAndroid*>(
+ MediaRouterFactory::GetApiForBrowserContext(
+ initiator()->GetBrowserContext()));
+ DCHECK(router);
+ router->CreateRoute(source_id,
+ ConvertJavaStringToUTF8(env, jsink_id),
+ origin,
+ SessionTabHelper::IdForTab(initiator()),
+ route_response_callbacks);
+}
+
+void MediaRouterDialogControllerAndroid::OnDialogDismissed(
+ JNIEnv* env, jobject obj) {
+ scoped_ptr<CreatePresentationSessionRequest> request(
+ PassPresentationRequest());
+
+ // If OnDialogDismissed is called after OnSinkSelected, do nothing.
+ if (!request)
+ return;
+
+ request->MaybeInvokeErrorCallback(content::PresentationError(
+ content::PRESENTATION_ERROR_SESSION_REQUEST_CANCELLED,
+ "The device picker dialog has been dismissed"));
+}
+
MediaRouterDialogControllerAndroid::MediaRouterDialogControllerAndroid(
WebContents* web_contents)
: MediaRouterDialogController(web_contents) {
@@ -42,8 +84,7 @@ MediaRouterDialogControllerAndroid::MediaRouterDialogControllerAndroid(
// static
bool MediaRouterDialogControllerAndroid::Register(JNIEnv* env) {
bool ret = RegisterNativesImpl(env);
- // No native calls to register yet.
- // DCHECK(g_ChromeMediaRouterDialogController_clazz);
+ DCHECK(g_ChromeMediaRouterDialogController_clazz);
return ret;
}
@@ -53,12 +94,8 @@ MediaRouterDialogControllerAndroid::~MediaRouterDialogControllerAndroid() {
void MediaRouterDialogControllerAndroid::CreateMediaRouterDialog() {
JNIEnv* env = base::android::AttachCurrentThread();
- scoped_ptr<CreatePresentationSessionRequest> presentation_request(
- PassPresentationRequest());
-
ScopedJavaLocalRef<jstring> jsource_urn =
- base::android::ConvertUTF8ToJavaString(
- env, presentation_request->media_source().id());
+ base::android::ConvertUTF8ToJavaString(env, GetMediaSourceId());
Java_ChromeMediaRouterDialogController_createDialog(
env, java_dialog_controller_.obj(), jsource_urn.obj());

Powered by Google App Engine
This is Rietveld 408576698