[Presentation API, MediaRouter] Routing from media sink selection to route creation.

chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/MediaSink.java

Index: chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/MediaSink.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/MediaSink.java b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/MediaSink.java
index 3ea7e098c7aabc1d9efe8401f7a8a216e53e4be1..f3d167ea9bc37bcc450defdbbd13d97062e6298b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/MediaSink.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/router/cast/MediaSink.java
@@ -5,6 +5,7 @@
 package org.chromium.chrome.browser.media.router.cast;
 
 import android.support.v7.media.MediaRouter;
+import android.support.v7.media.MediaRouter.RouteInfo;

[mlamouri (slow - plz ping), 2015/08/18 13:44:01]

nit: why do you need the import?

[whywhat, 2015/08/18 14:23:15]

As I understand it's either that or the java doc below will look like {@link
android.support.v7.media.MediaRouter.RouteInfo}.

 
 /**
  * A common descriptor of a device that can present some URI.
@@ -50,7 +51,12 @@ public class MediaSink {
         return result;
     }
 
-    static MediaSink fromRoute(MediaRouter.RouteInfo route) {
+    /**
+     * Returns a MediaSink instance corresponding to the specified {@link RouteInfo}.
+     * @param route the route information provided by Android
+     * @return a new MediaSink instance
+     */
+    public static MediaSink fromRoute(MediaRouter.RouteInfo route) {

[mlamouri (slow - plz ping), 2015/08/18 13:44:01]

It might be a stupid question but could you have a MediaSink ctor taking a
RouteInfo?

[whywhat, 2015/08/18 14:23:15]

I was inspired by
https://jlordiales.wordpress.com/2012/12/26/static-factory-methods-vs-traditi...

         return new MediaSink(
             route.getId(),
             route.getName());