Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc

Issue 1294113005: Atomic: Don’t keep track of Cursor planes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Include drm_fourcc.h again Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc
diff --git a/ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc b/ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc
index 2477e3797f162979e987a1185c8f303633cd5680..e1f4bb636958047f20c2b2ab3bdae6a29d2d69c0 100644
--- a/ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc
+++ b/ui/ozone/platform/drm/gpu/hardware_display_plane_atomic.cc
@@ -86,17 +86,9 @@ bool HardwareDisplayPlaneAtomic::SetPlaneData(drmModePropertySet* property_set,
return true;
}
-bool HardwareDisplayPlaneAtomic::Initialize(
+bool HardwareDisplayPlaneAtomic::InitializeProperties(
DrmDevice* drm,
- const std::vector<uint32_t>& formats) {
- ScopedDrmObjectPropertyPtr plane_props(drmModeObjectGetProperties(
- drm->get_fd(), plane_id_, DRM_MODE_OBJECT_PLANE));
-
- if (!plane_props) {
- PLOG(ERROR) << "Unable to get plane properties.";
- return false;
- }
-
+ const ScopedDrmObjectPropertyPtr& plane_props) {
bool props_init = crtc_prop_.Initialize(drm, kCrtcPropName, plane_props) &&
fb_prop_.Initialize(drm, kFbPropName, plane_props) &&
crtc_x_prop_.Initialize(drm, kCrtcXPropName, plane_props) &&
@@ -113,10 +105,6 @@ bool HardwareDisplayPlaneAtomic::Initialize(
return false;
}
- supported_formats_ = formats;
- if (is_dummy())
- supported_formats_.push_back(DRM_FORMAT_XRGB8888);
-
return true;
}

Powered by Google App Engine
This is Rietveld 408576698