Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: ui/ozone/platform/drm/gpu/hardware_display_plane.h

Issue 1294113005: Atomic: Don’t keep track of Cursor planes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Include drm_fourcc.h again Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/drm/gpu/hardware_display_plane.h
diff --git a/ui/ozone/platform/drm/gpu/hardware_display_plane.h b/ui/ozone/platform/drm/gpu/hardware_display_plane.h
index 778f344813a512762ab6ef1041174dbb878a2f00..4eecf8dfa099ee5f80e611183a5bca505d95377d 100644
--- a/ui/ozone/platform/drm/gpu/hardware_display_plane.h
+++ b/ui/ozone/platform/drm/gpu/hardware_display_plane.h
@@ -22,11 +22,15 @@ class DrmDevice;
class OZONE_EXPORT HardwareDisplayPlane {
public:
+ enum Type { kDummy, kPrimary, kOverlay, kCursor };
+
HardwareDisplayPlane(uint32_t plane_id, uint32_t possible_crtcs);
virtual ~HardwareDisplayPlane();
- virtual bool Initialize(DrmDevice* drm, const std::vector<uint32_t>& formats);
+ bool Initialize(DrmDevice* drm,
+ const std::vector<uint32_t>& formats,
+ bool is_dummy);
virtual bool IsSupportedFormat(uint32_t format) const;
@@ -35,20 +39,24 @@ class OZONE_EXPORT HardwareDisplayPlane {
bool in_use() const { return in_use_; }
void set_in_use(bool in_use) { in_use_ = in_use; }
- bool is_dummy() const { return is_dummy_; }
- void set_is_dummy(bool is_dummy) { is_dummy_ = is_dummy; }
-
uint32_t plane_id() const { return plane_id_; }
+ Type type() const { return type_; }
+
void set_owning_crtc(uint32_t crtc) { owning_crtc_ = crtc; }
uint32_t owning_crtc() const { return owning_crtc_; }
protected:
+ virtual bool InitializeProperties(
+ DrmDevice* drm,
+ const ScopedDrmObjectPropertyPtr& plane_props);
+
uint32_t plane_id_ = 0;
uint32_t possible_crtcs_ = 0;
uint32_t owning_crtc_ = 0;
bool in_use_ = false;
- bool is_dummy_ = false;
+ Type type_ = kPrimary;
+ std::vector<uint32_t> supported_formats_;
DISALLOW_COPY_AND_ASSIGN(HardwareDisplayPlane);
};

Powered by Google App Engine
This is Rietveld 408576698