Add library paths and rlink-paths for directories in the sysroot. (try 2)

Add library paths and rlink-paths for directories in the sysroot. (try 2)

TEST=Cross compiling with ld.bfd works.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189765

[Lei Zhang, 2013-03-19 21:23:54]

ChromeOS full builds use /build/$arch as the chroot, where there's only a
/build/$arch/etc/ld.so.conf.

I've rewritten sysroot_ld_path.sh to do more parsing, and to emit the library
paths in the order they are listed.

[Sam Clegg, 2013-03-19 21:31:14]

LGTM with a couple of comments.

Is there a policy about using .sh vs .py for this type of thing?  I would be
tempted to have done it in python, but thats mostly a personal preference.

https://codereview.chromium.org/12941005/diff/2001/build/linux/sysroot_ld_pat...
File build/linux/sysroot_ld_path.sh (right):

https://codereview.chromium.org/12941005/diff/2001/build/linux/sysroot_ld_pat...
build/linux/sysroot_ld_path.sh:1: #!/bin/sh
Are there no bashisms in here?

https://codereview.chromium.org/12941005/diff/2001/build/linux/sysroot_ld_pat...
build/linux/sysroot_ld_path.sh:11: 
Maybe set -x to catch any sub-commands that fail?

https://codereview.chromium.org/12941005/diff/2001/build/linux/sysroot_ld_pat...
build/linux/sysroot_ld_path.sh:71: echo $0 /abspath/to/sysroot
Maybe "Usage: ..."

https://codereview.chromium.org/12941005/diff/2001/build/linux/sysroot_ld_pat...
build/linux/sysroot_ld_path.sh:77: echo $1 contains whitespace.
Maybe $0 here too so its clean which tools reporting this error (although if its
only being run from gyp maybe gyp already reports this?)

[Lei Zhang, 2013-03-19 21:41:00]

Do you think this shell script is getting too hairy? If so, I'd be happy to
rewrite it in Python.

https://codereview.chromium.org/12941005/diff/2001/build/linux/sysroot_ld_pat...
File build/linux/sysroot_ld_path.sh (right):

https://codereview.chromium.org/12941005/diff/2001/build/linux/sysroot_ld_pat...
build/linux/sysroot_ld_path.sh:1: #!/bin/sh
On 2013/03/19 21:31:14, Sam Clegg wrote:
> Are there no bashisms in here?

There are no bashisms. I ran checkbashisms.

https://codereview.chromium.org/12941005/diff/2001/build/linux/sysroot_ld_pat...
build/linux/sysroot_ld_path.sh:11: 
On 2013/03/19 21:31:14, Sam Clegg wrote:
> Maybe set -x to catch any sub-commands that fail?

Did you mean "set -e" ? If we do that, we can probably just get rid of some of
the checks and just let it fail.

https://codereview.chromium.org/12941005/diff/2001/build/linux/sysroot_ld_pat...
build/linux/sysroot_ld_path.sh:71: echo $0 /abspath/to/sysroot
On 2013/03/19 21:31:14, Sam Clegg wrote:
> Maybe "Usage: ..."

Done.

https://codereview.chromium.org/12941005/diff/2001/build/linux/sysroot_ld_pat...
build/linux/sysroot_ld_path.sh:71: echo $0 /abspath/to/sysroot
On 2013/03/19 21:31:14, Sam Clegg wrote:
> Maybe "Usage: ..."

Done.

https://codereview.chromium.org/12941005/diff/2001/build/linux/sysroot_ld_pat...
build/linux/sysroot_ld_path.sh:77: echo $1 contains whitespace.
On 2013/03/19 21:31:14, Sam Clegg wrote:
> Maybe $0 here too so its clean which tools reporting this error (although if
its
> only being run from gyp maybe gyp already reports this?)

Done.

https://codereview.chromium.org/12941005/diff/2001/build/linux/sysroot_ld_pat...
build/linux/sysroot_ld_path.sh:77: echo $1 contains whitespace.
On 2013/03/19 21:31:14, Sam Clegg wrote:
> Maybe $0 here too so its clean which tools reporting this error (although if
its
> only being run from gyp maybe gyp already reports this?)

Added log_error_and_exit()

[Sam Clegg, 2013-03-19 21:56:46]

LGTM

[Lei Zhang, 2013-03-20 00:55:32]

The linux nacl_sdk try bot failed. Patch set 3 should make it work as well.

[Sam Clegg, 2013-03-20 00:58:39]

On 2013/03/20 00:55:32, Lei Zhang wrote:
> The linux nacl_sdk try bot failed. Patch set 3 should make it work as well.

LGTM

[commit-bot: I haz the power, 2013-03-20 01:33:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/12941005/13001

[commit-bot: I haz the power, 2013-03-20 01:54:52]

Retried try job too often on win7_aura for step(s) ash_unittests,
aura_unittests, browser_tests, compositor_unittests, content_browsertests,
content_unittests, interactive_ui_tests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[Lei Zhang, 2013-03-22 05:26:17]

Committed patchset #4 manually as r189765 (presubmit successful).