Chromium Code Reviews

Issue 1294063005: Recalculate intrinsic widths in the old containing block chain when going out of flow. (Closed)

Created:
5 years, 4 months ago by mstensho (USE GERRIT)
Modified:
5 years, 4 months ago
Reviewers:
leviw_travelin_and_unemployed, esprehn, eae, rhogan
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Recalculate intrinsic widths in the old containing block chain when going out of flow. When an object goes out of flow, it no longer contributes to the intrinisic widths of its parents. We need to mark them for recalculation while we can still walk that ancestry chain, i.e. before applying the style change. BUG=521819 R=esprehn@chromium.org,leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200836

Patch Set 1 #

Patch Set 2 : Make fast/layers/scroll-descendant-with-cached-cliprects.html NOT depend on the bug that this CL fi… #

Unified diffs Side-by-side diffs Stats (+28 lines, -1 line)
A LayoutTests/fast/block/positioning/static-to-abspos-parent-is-stf.html View 1 chunk +15 lines, -0 lines 0 comments
A LayoutTests/fast/block/positioning/static-to-abspos-parent-is-stf-expected.txt View 1 chunk +5 lines, -0 lines 0 comments
M LayoutTests/fast/layers/scroll-descendant-with-cached-cliprects.html View 1 chunk +1 line, -0 lines 0 comments
M Source/core/layout/LayoutBox.cpp View 1 chunk +7 lines, -1 line 0 comments

Messages

Total messages: 9 (3 generated)
mstensho (USE GERRIT)
5 years, 4 months ago (2015-08-18 08:01:19 UTC) #1
mstensho (USE GERRIT)
fast/layers/scroll-descendant-with-cached-cliprects.html depended on this bug (failure to recalculate intrinsic widths when a child is going ...
5 years, 4 months ago (2015-08-18 11:36:04 UTC) #3
eae
LGTM
5 years, 4 months ago (2015-08-19 15:40:18 UTC) #5
esprehn
lgtm
5 years, 4 months ago (2015-08-19 16:50:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294063005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294063005/20001
5 years, 4 months ago (2015-08-19 16:51:05 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 18:05:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200836

Powered by Google App Engine