Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1294043002: Mojom compiler: Improves error message by giving misspelled identifier. (Closed)

Created:
5 years, 4 months ago by rudominer
Modified:
5 years, 4 months ago
Reviewers:
azani
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mojom compiler: Improves error message by giving misspelled identifier. Instead of printing a meaningless Python object ID and a cryptic Python error print "unrecognized kind" and the type-spec for the unrecognized kind. This came up for me when I was writing a longer .mojom file and I had misspelled the name of one of my structs when I was attempting to include the struct in a union. The compiler told me something was wrong but I had no idea which identifier I had misspelled. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ae32942fcbd444484021dab26ccc508e0e1d52ce

Patch Set 1 #

Patch Set 2 : Add comment as requested in code review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
rudominer
5 years, 4 months ago (2015-08-17 03:35:41 UTC) #2
azani
lgtm Let's maybe add a TODO to remove it once we have re-written the front-end ...
5 years, 4 months ago (2015-08-17 08:50:28 UTC) #3
rudominer
5 years, 4 months ago (2015-08-17 16:19:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ae32942fcbd444484021dab26ccc508e0e1d52ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698