Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1294033002: Devtools: Fix tooltip z-index and add tooltip for dock side (Closed)

Created:
5 years, 4 months ago by samli
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Fix tooltip z-index and add tooltip for dock side Fix z-index of tooltips to appear on top of glass panes such as the new main menu. This also adds a tooltip for toggle dock side tooltip. BUG=520272, 521206 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200698

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/devtools/front_end/main/Main.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M Source/devtools/front_end/ui/tooltip.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
samli
5 years, 4 months ago (2015-08-17 01:01:33 UTC) #2
samli
Added tooltip for dockside shortcut: http://i.imgur.com/orgP7N6.png
5 years, 4 months ago (2015-08-17 01:29:49 UTC) #3
pfeldman
lgtm
5 years, 4 months ago (2015-08-17 18:56:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294033002/20001
5 years, 4 months ago (2015-08-17 23:24:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99392)
5 years, 4 months ago (2015-08-18 02:08:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294033002/20001
5 years, 4 months ago (2015-08-18 04:04:30 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 04:59:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200698

Powered by Google App Engine
This is Rietveld 408576698