Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1294023007: Revert of Add tryserver.infra to Rietveld. (Closed)

Created:
5 years, 4 months ago by tandrii(chromium)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, rmistry+cc_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Revert of Add tryserver.infra to Rietveld. (patchset #1 id:1 of https://codereview.chromium.org/1283133004/ ) Reason for revert: Because we don't have and can't easily have TryJobRietveld inside our master definition. So, let's not confuse people - scheduling from Rietveld won't work. See http://crbug.com/403494#42 for more. Original issue's description: > Add tryserver.infra to Rietveld. > > BUG=403494 > > Committed: https://chromium.googlesource.com/infra/infra/+/1f556d3a26310188ebd8e4b36282b0970e617de9 TBR=jrobbins@chromium.org,akuegel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=403494 Committed: https://chromium.googlesource.com/infra/infra/+/8ee5e0d08274d7862f49403b4f80c43592c013d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M appengine/chromium_rietveld/codereview/models_chromium.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tandrii(chromium)
Created Revert of Add tryserver.infra to Rietveld.
5 years, 4 months ago (2015-08-18 16:08:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294023007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294023007/1
5 years, 4 months ago (2015-08-18 16:08:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/8ee5e0d08274d7862f49403b4f80c43592c013d9
5 years, 4 months ago (2015-08-18 16:08:29 UTC) #3
Jason Robbins -- corp
lgtm
5 years, 4 months ago (2015-08-18 16:48:34 UTC) #5
Jason Robbins -- corp
On 2015/08/18 at 16:48:34, Jason Robbins -- corp wrote: > lgtm This change is live ...
5 years, 4 months ago (2015-08-18 16:56:16 UTC) #6
tandrii(chromium)
5 years ago (2015-12-02 20:03:46 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1496673002/ by tandrii@chromium.org.

The reason for reverting is: and now that Rietveld schedules through
buildbucket, this will work..

Powered by Google App Engine
This is Rietveld 408576698