Issue 1294023004: Add dep on dart_snapshotter_bin label in dartx rule

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1294023004: Add dep on dart_snapshotter_bin label in dartx rule (Closed)

Created:
5 years, 4 months ago by jamesr

Modified:
5 years, 4 months ago

Reviewers:
zra

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add dep on dart_snapshotter_bin label in dartx rule This requires that //build/module_args/dart.gni provide a label for dart_snapshotter_bin and adds a dep in the dartx rule on the target. A future patch will add a way to download a prebuilt binary. R=zra@google.com, zra Committed: https://chromium.googlesource.com/external/mojo/+/7aa07cbc6c239ba6cbf2c166886eeac527ca8ffa

Patch Set 1 #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -1 line)			Patch
M	build/module_args/dart.gni	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/public/dart/BUILD.gn	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	mojo/public/dart/rules.gni	View	1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

https://codereview.chromium.org/1294023004/diff/1/mojo/public/dart/rules.gni File mojo/public/dart/rules.gni (right): https://codereview.chromium.org/1294023004/diff/1/mojo/public/dart/rules.gni#newcode53 mojo/public/dart/rules.gni:53: dart_snapshotter_bin, If this variable isn't set, this will blow ...

5 years, 4 months ago (2015-08-17 21:05:25 UTC) #1

jamesr

5 years, 4 months ago (2015-08-17 21:17:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7aa07cbc6c239ba6cbf2c166886eeac527ca8ffa (presubmit successful).

Expand Messages | Collapse Messages