Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1294013002: SkPaintFilterCanvas should inherit the target canvas state (Closed)

Created:
5 years, 4 months ago by f(malita)
Modified:
5 years, 4 months ago
CC:
reviews_skia.org, hush (inactive)
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPaintFilterCanvas should inherit the target canvas state Currently, SkPaintFilterCanvas does not provide any help in cloning target canvas state. While that could be handled in subclasses, it is easy to miss (see linked bug). This CL adds a new constructor variant which ensures that the initial matrix and clip bounds are inherited from the target canvas. BUG=516790 R=reed@google.com,robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/f433bb2bebd441cc0b2b152e8fbf79eac43baf5d

Patch Set 1 #

Patch Set 2 : comment tweak #

Patch Set 3 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M include/utils/SkPaintFilterCanvas.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/utils/SkPaintFilterCanvas.cpp View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M tests/CanvasTest.cpp View 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294013002/40001
5 years, 4 months ago (2015-08-16 08:34:23 UTC) #2
f(malita)
5 years, 4 months ago (2015-08-16 08:37:16 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-16 08:40:23 UTC) #5
reed1
lgtm is the intended client chrome?
5 years, 4 months ago (2015-08-17 14:44:24 UTC) #7
f(malita)
On 2015/08/17 14:44:24, reed1 wrote: > lgtm > > is the intended client chrome? Yes, ...
5 years, 4 months ago (2015-08-17 14:51:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1294013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1294013002/40001
5 years, 4 months ago (2015-08-17 14:59:13 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 15:05:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f433bb2bebd441cc0b2b152e8fbf79eac43baf5d

Powered by Google App Engine
This is Rietveld 408576698