Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1294003002: clang/win: Enable -Wswitch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 841 matching lines...) Expand 10 before | Expand all | Expand 10 after
852 } 852 }
853 853
854 # Building with Clang on Windows is a work in progress and very 854 # Building with Clang on Windows is a work in progress and very
855 # experimental. See crbug.com/82385. 855 # experimental. See crbug.com/82385.
856 # Keep this in sync with the similar block in build/common.gypi 856 # Keep this in sync with the similar block in build/common.gypi
857 if (is_clang) { 857 if (is_clang) {
858 default_warning_flags += [ 858 default_warning_flags += [
859 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657 859 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657
860 "-Qunused-arguments", # http://crbug.com/504658 860 "-Qunused-arguments", # http://crbug.com/504658
861 "-Wno-microsoft", # http://crbug.com/505296 861 "-Wno-microsoft", # http://crbug.com/505296
862 "-Wno-switch", # http://crbug.com/505308
863 "-Wno-unknown-pragmas", # http://crbug.com/505314 862 "-Wno-unknown-pragmas", # http://crbug.com/505314
864 "-Wno-unused-value", # http://crbug.com/505318 863 "-Wno-unused-value", # http://crbug.com/505318
865 ] 864 ]
866 } 865 }
867 } else { 866 } else {
868 # Common GCC warning setup. 867 # Common GCC warning setup.
869 default_warning_flags += [ 868 default_warning_flags += [
870 # Enables. 869 # Enables.
871 "-Wendif-labels", # Weird old-style text after an #endif. 870 "-Wendif-labels", # Weird old-style text after an #endif.
872 "-Werror", # Warnings as errors. 871 "-Werror", # Warnings as errors.
(...skipping 459 matching lines...) Expand 10 before | Expand all | Expand 10 after
1332 cflags += [ "-gsplit-dwarf" ] 1331 cflags += [ "-gsplit-dwarf" ]
1333 } 1332 }
1334 } 1333 }
1335 } 1334 }
1336 1335
1337 config("no_symbols") { 1336 config("no_symbols") {
1338 if (!is_win) { 1337 if (!is_win) {
1339 cflags = [ "-g0" ] 1338 cflags = [ "-g0" ]
1340 } 1339 }
1341 } 1340 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698