Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 1293973004: Removed a redundant mouse-state from EventHandler. (Closed)

Created:
5 years, 4 months ago by mustaq
Modified:
5 years, 4 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, dtapuska
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removed a redundant mouse-state from EventHandler. EventHandler currently have two state vars for tracking node under mouse: m_nodeUnderMouse and m_lastNodeUnderMouse. These two pointers are used primarily for mouse entry/exit events, but they point to the same node until we are about to send mouseenter/leave/over/out events. In the few cases these pointers become unequal otherwise (happens only when dispathMouseEvent is called with setUnder=false), it is not clear why we didn't update the old state. My experiments suggest that updating the old state doesn't hurt in these cases. So it makes sense to nuke the m_lastNodeUnderMouse state. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201023

Patch Set 1 #

Patch Set 2 : Fixed a raw-ptr issue on deleted node. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -60 lines) Patch
M Source/core/input/EventHandler.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/input/EventHandler.cpp View 1 20 chunks +50 lines, -57 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293973004/1
5 years, 4 months ago (2015-08-19 16:55:34 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/95406)
5 years, 4 months ago (2015-08-19 18:05:40 UTC) #4
mustaq
ptal
5 years, 4 months ago (2015-08-20 14:54:50 UTC) #7
Rick Byers
Nice simplification!!! There's of course always some risk around this code that subtle behavior changes ...
5 years, 4 months ago (2015-08-21 14:08:32 UTC) #8
mustaq
On 2015/08/21 14:08:32, Rick Byers wrote: > Nice simplification!!! > > There's of course always ...
5 years, 4 months ago (2015-08-21 20:06:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293973004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293973004/40001
5 years, 4 months ago (2015-08-21 20:07:43 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 22:44:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201023

Powered by Google App Engine
This is Rietveld 408576698