Cleanup CFX_Font a bit.

Cleanup CFX_Font a bit.

- Make methods const.
- Make variables non-public.
- Remove LoadFile() method.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/e1ce94e0b045b443976c118a251400b4016f9811

[Lei Zhang, 2015-08-17 17:46:18]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2015-08-17 18:38:01]

https://codereview.chromium.org/1293973002/diff/20001/core/include/fxge/fx_fo...
File core/include/fxge/fx_font.h (right):

https://codereview.chromium.org/1293973002/diff/20001/core/include/fxge/fx_fo...
core/include/fxge/fx_font.h:67: 
nit: maybe kill the doublespacing between decls in this class while we're at it.

https://codereview.chromium.org/1293973002/diff/20001/core/include/fxge/fx_fo...
core/include/fxge/fx_font.h:72: CFX_PathData* LoadGlyphPath(FX_DWORD
glyph_index, int dest_width = 0);
nit: maybe kill the default argument and be explicit at the call sites if it's
not too much trouble.

https://codereview.chromium.org/1293973002/diff/20001/core/src/fpdfapi/fpdf_f...
File core/src/fpdfapi/fpdf_font/fpdf_font.cpp (right):

https://codereview.chromium.org/1293973002/diff/20001/core/src/fpdfapi/fpdf_f...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:278: m_pFontFile = nullptr;
is this a leak?

https://codereview.chromium.org/1293973002/diff/20001/core/src/fpdfapi/fpdf_f...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:1092: FXFT_Face face =
m_Font.GetFace();
We're sure no other methods change this value?

https://codereview.chromium.org/1293973002/diff/20001/core/src/fpdfapi/fpdf_f...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:1436: FXFT_Face face =
m_Font.GetFace();
ditto

[Lei Zhang, 2015-08-18 06:10:53]

https://codereview.chromium.org/1293973002/diff/20001/core/include/fxge/fx_fo...
File core/include/fxge/fx_font.h (right):

https://codereview.chromium.org/1293973002/diff/20001/core/include/fxge/fx_fo...
core/include/fxge/fx_font.h:67: 
On 2015/08/17 18:38:01, Tom Sepez wrote:
> nit: maybe kill the doublespacing between decls in this class while we're at
it.

Done.

https://codereview.chromium.org/1293973002/diff/20001/core/include/fxge/fx_fo...
core/include/fxge/fx_font.h:72: CFX_PathData* LoadGlyphPath(FX_DWORD
glyph_index, int dest_width = 0);
On 2015/08/17 18:38:01, Tom Sepez wrote:
> nit: maybe kill the default argument and be explicit at the call sites if it's
> not too much trouble.

There's lots of default arguments all over the place. We can deal with those
later.

https://codereview.chromium.org/1293973002/diff/20001/core/src/fpdfapi/fpdf_f...
File core/src/fpdfapi/fpdf_font/fpdf_font.cpp (right):

https://codereview.chromium.org/1293973002/diff/20001/core/src/fpdfapi/fpdf_f...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:278: m_pFontFile = nullptr;
On 2015/08/17 18:38:01, Tom Sepez wrote:
> is this a leak?

Probably. Also weird that it doesn't check the LoadEmbedded() return result
right above.

https://codereview.chromium.org/1293973002/diff/20001/core/src/fpdfapi/fpdf_f...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:1092: FXFT_Face face =
m_Font.GetFace();
On 2015/08/17 18:38:01, Tom Sepez wrote:
> We're sure no other methods change this value?

I'll just change it back to GetFace() to be on the safe side.

https://codereview.chromium.org/1293973002/diff/20001/core/src/fpdfapi/fpdf_f...
core/src/fpdfapi/fpdf_font/fpdf_font.cpp:1436: FXFT_Face face =
m_Font.GetFace();
On 2015/08/17 18:38:01, Tom Sepez wrote:
> ditto

ditto ditto

[Tom Sepez, 2015-08-18 14:56:40]

lgtm

[Lei Zhang, 2015-08-18 22:40:04]

Committed patchset #5 (id:80001) manually as
e1ce94e0b045b443976c118a251400b4016f9811 (presubmit successful).