components/guest_view/browser/guest_view_base.h - Issue 1293963002: Fixing the Position of Context Menu for BrowserPlugin (<webview>)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/guest_view/browser/guest_view_base.h

Issue 1293963002: Fixing the Position of Context Menu for BrowserPlugin (<webview>) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed a Build Error in MAC Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/context_menus/coordinates_with_transforms/test.js ('k') | components/guest_view/browser/guest_view_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/guest_view/browser/guest_view_base.h

diff --git a/components/guest_view/browser/guest_view_base.h b/components/guest_view/browser/guest_view_base.h

index 3ea4265621f770d76910b943a8db48538a4a66ad..6c7864506a7c48eed7b0250bf9a4a2763bce7877 100644

--- a/components/guest_view/browser/guest_view_base.h

+++ b/components/guest_view/browser/guest_view_base.h

@@ -271,7 +271,6 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

void SetAttachParams(const base::DictionaryValue& params);

void SetOpener(GuestViewBase* opener);

- // BrowserPluginGuestDelegate implementation.

content::WebContents* CreateNewGuestWindow(

const content::WebContents::CreateParams& create_params) final;

void DidAttach(int guest_proxy_routing_id) final;

@@ -369,6 +368,9 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

// entirety of the embedder's content.

virtual bool ShouldHandleFindRequestsForEmbedder() const;

+ // BrowserPluginGuestDelegate implementation.

+ void SetContextMenuPosition(const gfx::Point& position) override;

private:

class OwnerContentsObserver;