chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h - Issue 1293963002: Fixing the Position of Context Menu for BrowserPlugin (<webview>)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

Issue 1293963002: Fixing the Position of Context Menu for BrowserPlugin (<webview>) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed a Build Error in MAC Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc ('k') | chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

index 7b4c1451baae4214a478faab455a4c01a54f0754..d6101e7a63b14df35efa1cffbd5bd08de0e64139 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h

@@ -39,6 +39,8 @@ class ChromeWebViewGuestDelegate : public WebViewGuestDelegate {

return web_view_guest()->web_contents();

}

+ void SetContextMenuPosition(const gfx::Point& position) override;

// Returns the top level items (ignoring submenus) as Value.

static scoped_ptr<base::ListValue> MenuModelToValue(

const ui::SimpleMenuModel& menu_model);

@@ -70,6 +72,8 @@ class ChromeWebViewGuestDelegate : public WebViewGuestDelegate {

WebViewGuest* const web_view_guest_;

+ scoped_ptr<gfx::Point> context_menu_position_;

// This is used to ensure pending tasks will not fire after this object is

// destroyed.

base::WeakPtrFactory<ChromeWebViewGuestDelegate> weak_ptr_factory_;