Refactor qualified send sets.

pkg/compiler/lib/src/elements/elements.dart

Index: pkg/compiler/lib/src/elements/elements.dart
diff --git a/pkg/compiler/lib/src/elements/elements.dart b/pkg/compiler/lib/src/elements/elements.dart
index ed40c2908ecb768e012f2130ea376af3478c5faf..ade7fa3a637dc9d4a5fb2b4cece4db5e7a8507ce 100644
--- a/pkg/compiler/lib/src/elements/elements.dart
+++ b/pkg/compiler/lib/src/elements/elements.dart
@@ -521,7 +521,7 @@ class Elements {
     if (element == null) return !isClosureSend(send, element);
     return isInstanceMethod(element) ||
            isInstanceField(element) ||
-           send.isConditional;
+           (send.isConditional && !element.isStatic);

[Siggi Cherem (dart-lang), 2015/08/24 21:25:17]

I think it should be fine to delete this whole line, if !element.isStatic, one
of the other two conditions will be true already.

[Johnni Winther, 2015/08/25 07:25:58]

This makes C?.foo _not_ an instance-send.

[Siggi Cherem (dart-lang), 2015/08/25 15:48:06]

I'm probably missing something - isInstanceMethod and isInstanceField are always
false when element.isStatic. So it seems to me that this condition is equivalent
to:

  return isInstanceMethod(element) || isInstnaceField(element);

(when I added `send.isConditional` it only added it because C?.foo used to be an
instance-send, now that this is no longer true, I thought we wouldn't need the
special case for send.isConditional altogether)

[Johnni Winther, 2015/08/26 07:18:35]

Ahh. I didn't go into the cases of isInstanceMethod and isInstanceField. In any
case, methods like this should be removed and replaced by predicates on elements
if necessary. Not only is the reasoning often unclear, the implementation is
also based on a closed world of elements.

   }
 
   static bool isClosureSend(Send send, Element element) {
@@ -660,12 +660,6 @@ class Elements {
     return null;
   }
 
-  static String mapToUserOperator(String op) {
-    String userOperator = mapToUserOperatorOrNull(op);
-    if (userOperator == null) throw 'Unhandled operator: $op';
-    else return userOperator;
-  }
-
   static bool isNumberOrStringSupertype(Element element, Compiler compiler) {
     LibraryElement coreLibrary = compiler.coreLibrary;
     return (element == coreLibrary.find('Comparable'));