Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: Source/core/html/shadow/PickerIndicatorElement.cpp

Issue 1293953003: Fix flaky crash in WebPagePopupImpl::closePopup. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 PassRefPtrWillBeRawPtr<PickerIndicatorElement> PickerIndicatorElement::create(Do cument& document, PickerIndicatorOwner& pickerIndicatorOwner) 56 PassRefPtrWillBeRawPtr<PickerIndicatorElement> PickerIndicatorElement::create(Do cument& document, PickerIndicatorOwner& pickerIndicatorOwner)
57 { 57 {
58 RefPtrWillBeRawPtr<PickerIndicatorElement> element = adoptRefWillBeNoop(new PickerIndicatorElement(document, pickerIndicatorOwner)); 58 RefPtrWillBeRawPtr<PickerIndicatorElement> element = adoptRefWillBeNoop(new PickerIndicatorElement(document, pickerIndicatorOwner));
59 element->setShadowPseudoId(AtomicString("-webkit-calendar-picker-indicator", AtomicString::ConstructFromLiteral)); 59 element->setShadowPseudoId(AtomicString("-webkit-calendar-picker-indicator", AtomicString::ConstructFromLiteral));
60 element->setAttribute(idAttr, ShadowElementNames::pickerIndicator()); 60 element->setAttribute(idAttr, ShadowElementNames::pickerIndicator());
61 return element.release(); 61 return element.release();
62 } 62 }
63 63
64 PickerIndicatorElement::~PickerIndicatorElement() 64 PickerIndicatorElement::~PickerIndicatorElement()
65 { 65 {
66 closePopup();
67 ASSERT(!m_chooser); 66 ASSERT(!m_chooser);
68 } 67 }
69 68
70 LayoutObject* PickerIndicatorElement::createLayoutObject(const ComputedStyle&) 69 LayoutObject* PickerIndicatorElement::createLayoutObject(const ComputedStyle&)
71 { 70 {
72 return new LayoutDetailsMarker(this); 71 return new LayoutDetailsMarker(this);
73 } 72 }
74 73
75 void PickerIndicatorElement::defaultEventHandler(Event* event) 74 void PickerIndicatorElement::defaultEventHandler(Event* event)
76 { 75 {
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 184
186 DEFINE_TRACE(PickerIndicatorElement) 185 DEFINE_TRACE(PickerIndicatorElement)
187 { 186 {
188 visitor->trace(m_pickerIndicatorOwner); 187 visitor->trace(m_pickerIndicatorOwner);
189 HTMLDivElement::trace(visitor); 188 HTMLDivElement::trace(visitor);
190 } 189 }
191 190
192 } 191 }
193 192
194 #endif 193 #endif
OLDNEW
« no previous file with comments | « Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698