Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 1293953003: Fix flaky crash in WebPagePopupImpl::closePopup. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 1505 matching lines...) Expand 10 before | Expand all | Expand 10 after
1516 } 1516 }
1517 HTMLTextFormControlElement::insertedInto(insertionPoint); 1517 HTMLTextFormControlElement::insertedInto(insertionPoint);
1518 if (insertionPoint->inDocument() && !form()) 1518 if (insertionPoint->inDocument() && !form())
1519 addToRadioButtonGroup(); 1519 addToRadioButtonGroup();
1520 resetListAttributeTargetObserver(); 1520 resetListAttributeTargetObserver();
1521 return InsertionShouldCallDidNotifySubtreeInsertions; 1521 return InsertionShouldCallDidNotifySubtreeInsertions;
1522 } 1522 }
1523 1523
1524 void HTMLInputElement::removedFrom(ContainerNode* insertionPoint) 1524 void HTMLInputElement::removedFrom(ContainerNode* insertionPoint)
1525 { 1525 {
1526 m_inputTypeView->closePopupView();
1526 if (insertionPoint->inDocument() && !form()) 1527 if (insertionPoint->inDocument() && !form())
1527 removeFromRadioButtonGroup(); 1528 removeFromRadioButtonGroup();
1528 HTMLTextFormControlElement::removedFrom(insertionPoint); 1529 HTMLTextFormControlElement::removedFrom(insertionPoint);
1529 ASSERT(!inDocument()); 1530 ASSERT(!inDocument());
1530 resetListAttributeTargetObserver(); 1531 resetListAttributeTargetObserver();
1531 } 1532 }
1532 1533
1533 void HTMLInputElement::didMoveToNewDocument(Document& oldDocument) 1534 void HTMLInputElement::didMoveToNewDocument(Document& oldDocument)
1534 { 1535 {
1535 if (imageLoader()) 1536 if (imageLoader())
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
1925 void HTMLInputElement::ensurePrimaryContent() 1926 void HTMLInputElement::ensurePrimaryContent()
1926 { 1927 {
1927 m_inputTypeView->ensurePrimaryContent(); 1928 m_inputTypeView->ensurePrimaryContent();
1928 } 1929 }
1929 1930
1930 bool HTMLInputElement::hasFallbackContent() const 1931 bool HTMLInputElement::hasFallbackContent() const
1931 { 1932 {
1932 return m_inputTypeView->hasFallbackContent(); 1933 return m_inputTypeView->hasFallbackContent();
1933 } 1934 }
1934 } // namespace 1935 } // namespace
OLDNEW
« no previous file with comments | « no previous file | Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698