Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1293903002: DevTools: Nuke timeline costly functions flamechart experiment (Closed)

Created:
5 years, 4 months ago by alph
Modified:
5 years, 4 months ago
Reviewers:
caseq, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Nuke timeline costly functions flamechart experiment R=yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200590

Patch Set 1 #

Patch Set 2 : fix the condition #

Patch Set 3 : update the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -293 lines) Patch
M LayoutTests/inspector/tracing/timeline-js-callstacks.html View 1 2 1 chunk +19 lines, -7 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-js-callstacks-expected.txt View 1 2 1 chunk +49 lines, -37 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 1 chunk +0 lines, -161 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 5 chunks +4 lines, -87 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
alph
5 years, 4 months ago (2015-08-14 19:12:02 UTC) #2
caseq
lgtm
5 years, 4 months ago (2015-08-14 19:13:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293903002/1
5 years, 4 months ago (2015-08-14 19:13:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/56885) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-14 19:15:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293903002/40001
5 years, 4 months ago (2015-08-14 23:26:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/57018) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-14 23:28:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293903002/40001
5 years, 4 months ago (2015-08-14 23:53:17 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 02:23:34 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200590

Powered by Google App Engine
This is Rietveld 408576698