Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Issue 12939002: IndexedDB: Remove unused plumbing for string version changes (Closed)

Created:
7 years, 9 months ago by jsbell
Modified:
7 years, 9 months ago
Reviewers:
Tom Sepez, alecflett
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

IndexedDB: Remove unused plumbing for string version changes Just deleting dead code. BUG=222067 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -33 lines) Patch
M content/browser/in_process_webkit/indexed_db_database_callbacks.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_database_callbacks.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
jsbell
Bleah, not actually dead. The back end sends onVersionChange(NoStringVersion) during delete instead of NoIntVersion
7 years, 9 months ago (2013-03-19 16:51:24 UTC) #1
alecflett
lgtm lgtm
7 years, 9 months ago (2013-03-19 17:04:32 UTC) #2
jsbell
Turns out this is used, I'll have to do a 3-part/2-sided patch to remove this.
7 years, 9 months ago (2013-03-19 17:12:09 UTC) #3
jsbell
Landing sequence: WK Part 1: https://bugs.webkit.org/show_bug.cgi?id=112715 This Chromium patch WK Part 2: https://bugs.webkit.org/show_bug.cgi?id=112712
7 years, 9 months ago (2013-03-19 17:51:13 UTC) #4
jsbell
Waiting for WK to roll to 146225...
7 years, 9 months ago (2013-03-19 19:03:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/12939002/1
7 years, 9 months ago (2013-03-20 19:42:56 UTC) #6
commit-bot: I haz the power
Presubmit check for 12939002-1 failed and returned exit status 1. INFO:root:Found 5 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-20 19:42:59 UTC) #7
jsbell
tsepez@ - IPC review?
7 years, 9 months ago (2013-03-20 20:03:11 UTC) #8
Tom Sepez
Rubberstamp LGTM on deleting messages.
7 years, 9 months ago (2013-03-20 20:28:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/12939002/1
7 years, 9 months ago (2013-03-20 20:56:12 UTC) #10
commit-bot: I haz the power
7 years, 9 months ago (2013-03-21 02:50:03 UTC) #11
Message was sent while issue was closed.
Change committed as 189502

Powered by Google App Engine
This is Rietveld 408576698