Expire resources in ResourcePool after non-use

cc/resources/resource_pool.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_RESOURCES_RESOURCE_POOL_H_
 #define CC_RESOURCES_RESOURCE_POOL_H_
 
 #include <deque>
 
 #include "base/containers/scoped_ptr_map.h"
@@ skipping 59 matching lines @@
         ResourceProvider* resource_provider) {
       return make_scoped_ptr(new PoolResource(resource_provider));
     }
     void OnMemoryDump(base::trace_event::ProcessMemoryDump* pmd,
                       const ResourceProvider* resource_provider,
                       bool is_free) const;
 
     uint64_t content_id() const { return content_id_; }
     void set_content_id(uint64_t content_id) { content_id_ = content_id; }
 
+    base::TimeTicks last_usage() const { return last_usage_; }
+    void set_last_usage(base::TimeTicks time) { last_usage_ = time; }
+
    private:
     explicit PoolResource(ResourceProvider* resource_provider)
         : ScopedResource(resource_provider), content_id_(0) {}
     uint64_t content_id_;
+    base::TimeTicks last_usage_;
   };
 
   void DidFinishUsingResource(scoped_ptr<PoolResource> resource);
   void DeleteResource(scoped_ptr<PoolResource> resource);
+  void DeleteUnusedResource(scoped_ptr<PoolResource> resource);
+
+  // Functions which manage periodic eviction of expired resources.
+  void ScheduleEvictExpiredResources();
+  void EvictExpiredResources();
+  void EvictResourcesNotUsedSince(base::TimeTicks time_limit);
+  bool HasEvictableResources() const;
+  base::TimeTicks GetUsageTimeForLRUResource() const;
 
   ResourceProvider* resource_provider_;
   const GLenum target_;
   size_t max_memory_usage_bytes_;
   size_t max_unused_memory_usage_bytes_;

[reveman, 2015/08/20 21:43:37]

Let's remove all traces of unused usage based eviction in this cl as it's no
longer needed when adding this time based eviction.

[ericrk, 2015/08/21 12:48:22]

Done.

   size_t max_resource_count_;
   size_t memory_usage_bytes_;
   size_t unused_memory_usage_bytes_;

[reveman, 2015/08/20 21:43:37]

I think this member can also be removed.

[ericrk, 2015/08/21 12:48:22]

This is still sort of nice to track - we trace this value in tile_manager for
instance, and I could see this being an UMA stat. What do you think?

   size_t resource_count_;
 
   using ResourceDeque = ScopedPtrDeque<PoolResource>;
   ResourceDeque unused_resources_;
   ResourceDeque busy_resources_;
 
   using ResourceMap = base::ScopedPtrMap<ResourceId, scoped_ptr<PoolResource>>;
   ResourceMap in_use_resources_;
 
+  bool evict_expired_resources_pending_;
+  base::TimeDelta resource_expiration_delay_;
+  base::Closure evict_expired_resources_callback_;
+
+  base::WeakPtrFactory<ResourcePool> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(ResourcePool);
 };
 
 }  // namespace cc
 
 #endif  // CC_RESOURCES_RESOURCE_POOL_H_