Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1293873003: [Fetch API] Remove unused code. (Closed)

Created:
5 years, 4 months ago by yhirano
Modified:
5 years, 4 months ago
Reviewers:
hiroshige
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Fetch API] Remove unused code. The outer FormData in RequestInit::RequestInit is shadowed by the inner one and completely useless. The variable was introduced at [1] and the bug was found by brucedawson@. 1: https://codereview.chromium.org/1301523002 BUG=457484 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200902

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/modules/fetch/RequestInit.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
yhirano
5 years, 4 months ago (2015-08-20 06:23:28 UTC) #2
hiroshige
lgtm. optional: Including a link to https://codereview.chromium.org/1301523002 in the CL description might be better for ...
5 years, 4 months ago (2015-08-20 06:26:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293873003/1
5 years, 4 months ago (2015-08-20 06:36:13 UTC) #5
yhirano
On 2015/08/20 06:26:24, hiroshige (ooo zombie) wrote: > lgtm. > > optional: Including a link ...
5 years, 4 months ago (2015-08-20 06:36:48 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/110860)
5 years, 4 months ago (2015-08-20 07:38:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293873003/1
5 years, 4 months ago (2015-08-20 07:39:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/58124)
5 years, 4 months ago (2015-08-20 12:28:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293873003/1
5 years, 4 months ago (2015-08-20 12:29:09 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 14:23:07 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200902

Powered by Google App Engine
This is Rietveld 408576698