chrome/test/data/prerender/prerender_session_storage.html - Issue 129383002: Better test coverage for prerender sessionStorage merging. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(9772)

My Issues | Starred Open | Closed | All

Unified Diff: chrome/test/data/prerender/prerender_session_storage.html

Issue 129383002: Better test coverage for prerender sessionStorage merging. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add TODO Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/test/data/prerender/init_session_storage.html ('k') | chrome/test/data/prerender/prerender_session_storage_conflict.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/prerender/prerender_session_storage.html

diff --git a/chrome/test/data/prerender/prerender_page.html b/chrome/test/data/prerender/prerender_session_storage.html

similarity index 50%

copy from chrome/test/data/prerender/prerender_page.html

copy to chrome/test/data/prerender/prerender_session_storage.html

index 06cd6f44a682761d120863a30a825c6ca79d08a7..b4c977553e754efa283227b94926779843e75659 100644

--- a/chrome/test/data/prerender/prerender_page.html

+++ b/chrome/test/data/prerender/prerender_session_storage.html

@@ -1,6 +1,7 @@

<html>

-<!--

-This test checks to make sure that a prerendered page is loaded.

+<!--

+This test checks to make sure that the prerendered page was loaded with the

+correct sessionStorage namespace.

-->

<head>

<title>Prerender Page</title>

@@ -13,10 +14,9 @@ function DidPrerenderPass() {

return true;

}

-// Make sure DidPrerenderPass() was called first. Otherwise, the page was

-// most likely reloaded instead of using the prerendered page.

+// Verify the sessionStorage value was set.

function DidDisplayPass() {

- return pageWasPrerendered;

+ return pageWasPrerendered && sessionStorage.value === "hello";

}

</script>

« no previous file with comments | « chrome/test/data/prerender/init_session_storage.html ('k') | chrome/test/data/prerender/prerender_session_storage_conflict.html » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698