chrome/browser/extensions/app_background_page_apitest.cc - Issue 1293813005: Change the new-task-manager flag so that the new implementation is enabled by default for all users.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/app_background_page_apitest.cc

Issue 1293813005: Change the new-task-manager flag so that the new implementation is enabled by default for all users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing old TM browser tests Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/processes/processes_apitest.cc ('k') | chrome/browser/prerender/prerender_browsertest.cc » ('j') | chrome/browser/task_manager/task_manager_browsertest_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/app_background_page_apitest.cc

diff --git a/chrome/browser/extensions/app_background_page_apitest.cc b/chrome/browser/extensions/app_background_page_apitest.cc

index c2556338d9fa38f3fbebfdf2bce96dac20b048e8..3e51aa063824fc8a156d7aca0130a461c2df654d 100644

--- a/chrome/browser/extensions/app_background_page_apitest.cc

+++ b/chrome/browser/extensions/app_background_page_apitest.cc

@@ -15,6 +15,7 @@

#include "chrome/browser/extensions/extension_apitest.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/profiles/profile.h"

+#include "chrome/browser/task_manager/task_manager_browsertest_util.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_dialogs.h"

#include "chrome/browser/ui/browser_window.h"

@@ -306,6 +307,9 @@ IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, NoJsBackgroundPage) {

// Keep the task manager up through this test to verify that a crash doesn't

// happen when window.open creates a background page that switches

// RenderViewHosts. See http://crbug.com/165138.

+ // This test is for the old implementation of the task manager. We must

+ // explicitly disable the new one.

+ task_manager::browsertest_util::EnableOldTaskManager();

chrome::ShowTaskManager(browser());

// Make sure that no BackgroundContentses get deleted (a signal that repeated