Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 1293813005: Change the new-task-manager flag so that the new implementation is enabled by default for all users. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing old TM browser tests Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <deque> 5 #include <deque>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 2471 matching lines...) Expand 10 before | Expand all | Expand 10 after
2482 2482
2483 // Cancel the prerender. 2483 // Cancel the prerender.
2484 GetPrerenderManager()->CancelAllPrerenders(); 2484 GetPrerenderManager()->CancelAllPrerenders();
2485 prerender->WaitForStop(); 2485 prerender->WaitForStop();
2486 2486
2487 // All prerenders are now gone. 2487 // All prerenders are now gone.
2488 EXPECT_TRUE(IsEmptyPrerenderLinkManager()); 2488 EXPECT_TRUE(IsEmptyPrerenderLinkManager());
2489 } 2489 }
2490 2490
2491 IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, OpenTaskManagerBeforePrerender) { 2491 IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, OpenTaskManagerBeforePrerender) {
2492 // This test is for the old implementation of the task manager. We must
2493 // explicitly disable the new one.
2494 task_manager::browsertest_util::EnableOldTaskManager();
2495
2492 const base::string16 any_prerender = MatchTaskManagerPrerender("*"); 2496 const base::string16 any_prerender = MatchTaskManagerPrerender("*");
2493 const base::string16 any_tab = MatchTaskManagerTab("*"); 2497 const base::string16 any_tab = MatchTaskManagerTab("*");
2494 const base::string16 original = MatchTaskManagerTab("Preloader"); 2498 const base::string16 original = MatchTaskManagerTab("Preloader");
2495 const base::string16 prerender = MatchTaskManagerPrerender("Prerender Page"); 2499 const base::string16 prerender = MatchTaskManagerPrerender("Prerender Page");
2496 const base::string16 final = MatchTaskManagerTab("Prerender Page"); 2500 const base::string16 final = MatchTaskManagerTab("Prerender Page");
2497 2501
2498 // Show the task manager. This populates the model. 2502 // Show the task manager. This populates the model.
2499 chrome::OpenTaskManager(current_browser()); 2503 chrome::OpenTaskManager(current_browser());
2500 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, any_tab)); 2504 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, any_tab));
2501 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, any_prerender)); 2505 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, any_prerender));
(...skipping 15 matching lines...) Expand all
2517 // The "Prerender: " TaskManager entry should disappear, being replaced by a 2521 // The "Prerender: " TaskManager entry should disappear, being replaced by a
2518 // "Tab: Prerender Page" entry, and nothing else. 2522 // "Tab: Prerender Page" entry, and nothing else.
2519 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, prerender)); 2523 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, prerender));
2520 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, original)); 2524 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, original));
2521 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, final)); 2525 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, final));
2522 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, any_tab)); 2526 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, any_tab));
2523 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, any_prerender)); 2527 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, any_prerender));
2524 } 2528 }
2525 2529
2526 IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, OpenTaskManagerAfterPrerender) { 2530 IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, OpenTaskManagerAfterPrerender) {
2531 // This test is for the old implementation of the task manager. We must
2532 // explicitly disable the new one.
2533 task_manager::browsertest_util::EnableOldTaskManager();
2534
2527 const base::string16 any_prerender = MatchTaskManagerPrerender("*"); 2535 const base::string16 any_prerender = MatchTaskManagerPrerender("*");
2528 const base::string16 any_tab = MatchTaskManagerTab("*"); 2536 const base::string16 any_tab = MatchTaskManagerTab("*");
2529 const base::string16 original = MatchTaskManagerTab("Preloader"); 2537 const base::string16 original = MatchTaskManagerTab("Preloader");
2530 const base::string16 prerender = MatchTaskManagerPrerender("Prerender Page"); 2538 const base::string16 prerender = MatchTaskManagerPrerender("Prerender Page");
2531 const base::string16 final = MatchTaskManagerTab("Prerender Page"); 2539 const base::string16 final = MatchTaskManagerTab("Prerender Page");
2532 2540
2533 // Start with two resources. 2541 // Start with two resources.
2534 PrerenderTestURL("files/prerender/prerender_page.html", FINAL_STATUS_USED, 1); 2542 PrerenderTestURL("files/prerender/prerender_page.html", FINAL_STATUS_USED, 1);
2535 2543
2536 // Show the task manager. This populates the model. Importantly, we're doing 2544 // Show the task manager. This populates the model. Importantly, we're doing
(...skipping 14 matching lines...) Expand all
2551 // The "Prerender: Prerender Page" TaskManager row should disappear, being 2559 // The "Prerender: Prerender Page" TaskManager row should disappear, being
2552 // replaced by "Tab: Prerender Page" 2560 // replaced by "Tab: Prerender Page"
2553 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, prerender)); 2561 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, prerender));
2554 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, original)); 2562 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, original));
2555 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, final)); 2563 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, final));
2556 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, any_tab)); 2564 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(1, any_tab));
2557 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, any_prerender)); 2565 ASSERT_NO_FATAL_FAILURE(WaitForTaskManagerRows(0, any_prerender));
2558 } 2566 }
2559 2567
2560 IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, OpenTaskManagerAfterSwapIn) { 2568 IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, OpenTaskManagerAfterSwapIn) {
2569 // This test is for the old implementation of the task manager. We must
2570 // explicitly disable the new one.
2571 task_manager::browsertest_util::EnableOldTaskManager();
2572
2561 const base::string16 any_prerender = MatchTaskManagerPrerender("*"); 2573 const base::string16 any_prerender = MatchTaskManagerPrerender("*");
2562 const base::string16 any_tab = MatchTaskManagerTab("*"); 2574 const base::string16 any_tab = MatchTaskManagerTab("*");
2563 const base::string16 final = MatchTaskManagerTab("Prerender Page"); 2575 const base::string16 final = MatchTaskManagerTab("Prerender Page");
2564 2576
2565 // Prerender, and swap it in. 2577 // Prerender, and swap it in.
2566 PrerenderTestURL("files/prerender/prerender_page.html", FINAL_STATUS_USED, 1); 2578 PrerenderTestURL("files/prerender/prerender_page.html", FINAL_STATUS_USED, 1);
2567 NavigateToDestURL(); 2579 NavigateToDestURL();
2568 2580
2569 // Show the task manager. This populates the model. Importantly, we're doing 2581 // Show the task manager. This populates the model. Importantly, we're doing
2570 // this after the prerender has been swapped in. 2582 // this after the prerender has been swapped in.
(...skipping 1575 matching lines...) Expand 10 before | Expand all | Expand 10 after
4146 4158
4147 NavigateToDestURL(); 4159 NavigateToDestURL();
4148 EXPECT_EQ(1U, task_manager.tasks().size()); 4160 EXPECT_EQ(1U, task_manager.tasks().size());
4149 } 4161 }
4150 4162
4151 } // namespace 4163 } // namespace
4152 4164
4153 #endif // defined(ENABLE_TASK_MANAGER) 4165 #endif // defined(ENABLE_TASK_MANAGER)
4154 4166
4155 } // namespace prerender 4167 } // namespace prerender
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698