Change the new-task-manager flag so that the new implementation is enabled by default for all users.

Change the new-task-manager flag so that the new implementation is enabled by default for all users.

Unless the user explicitly specifies the desire to revert back to the
old implementation using the flag, the new implementation should be
enabled by default.

R=thestig@chromium.org
BUG=520776, 471006
Committed: https://crrev.com/35c987ef7b7ea54d1e1b0f5139c6878fbf8c0bd8
Cr-Commit-Position: refs/heads/master@{#343558}

[afakhry, 2015-08-14 18:11:20]

afakhry@chromium.org changed reviewers:
+ asvitkine@chromium.org

[afakhry, 2015-08-14 18:11:21]

thestig@ and asvitkine@ Kindly please review. Thanks!

[Lei Zhang, 2015-08-14 18:17:47]

lgtm

https://codereview.chromium.org/1293813005/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1293813005/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:62205: -  <int value="-2063352474"
label="enable-new-task-manager"/>
I think you are suppose to never delete?

[Alexei Svitkine (slow), 2015-08-14 18:27:51]

lgtm % comment

https://codereview.chromium.org/1293813005/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1293813005/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:62205: -  <int value="-2063352474"
label="enable-new-task-manager"/>
On 2015/08/14 18:17:47, Lei Zhang wrote:
> I think you are suppose to never delete?

Correct. Please keep the old entry so that old data can be decoded.

[afakhry, 2015-08-14 18:36:05]

https://codereview.chromium.org/1293813005/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1293813005/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:62205: -  <int value="-2063352474"
label="enable-new-task-manager"/>
On 2015/08/14 18:27:51, Alexei Svitkine (OOO Aug15-24) wrote:
> On 2015/08/14 18:17:47, Lei Zhang wrote:
> > I think you are suppose to never delete?
> 
> Correct. Please keep the old entry so that old data can be decoded.

I should keep the old entry even though the old flag has been removed entirely?
Do we remove it at a later point in time?

[Alexei Svitkine (slow), 2015-08-14 18:45:32]

No, just keep it. It allows decoding data from old versions. (We only use
the latest histogram.xml file - rather than keeping a mapping of versions
to snapshots of histograms.xml files.)

On Fri, Aug 14, 2015 at 2:36 PM, <afakhry@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/1293813005/diff/1/tools/metrics/histograms/hi...
> File tools/metrics/histograms/histograms.xml (left):
>
>
>
https://codereview.chromium.org/1293813005/diff/1/tools/metrics/histograms/hi...
> tools/metrics/histograms/histograms.xml:62205: -  <int
> value="-2063352474" label="enable-new-task-manager"/>
> On 2015/08/14 18:27:51, Alexei Svitkine (OOO Aug15-24) wrote:
>
>> On 2015/08/14 18:17:47, Lei Zhang wrote:
>> > I think you are suppose to never delete?
>>
>
> Correct. Please keep the old entry so that old data can be decoded.
>>
>
> I should keep the old entry even though the old flag has been removed
> entirely? Do we remove it at a later point in time?
>
> https://codereview.chromium.org/1293813005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[afakhry, 2015-08-14 18:57:09]

https://codereview.chromium.org/1293813005/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1293813005/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:62205: -  <int value="-2063352474"
label="enable-new-task-manager"/>
On 2015/08/14 18:36:04, afakhry wrote:
> On 2015/08/14 18:27:51, Alexei Svitkine (OOO Aug15-24) wrote:
> > On 2015/08/14 18:17:47, Lei Zhang wrote:
> > > I think you are suppose to never delete?
> > 
> > Correct. Please keep the old entry so that old data can be decoded.
> 
> I should keep the old entry even though the old flag has been removed
entirely?
> Do we remove it at a later point in time?

Done.

[afakhry, 2015-08-14 22:38:29]

thestig@ Please take another look. The old task manager had very tight coupling
with the UI and testing its internals used to be done by running the UI and then
poking into the implementation. So for the old TM browser tests to run properly,
we need to disable the new implementation.

[Lei Zhang, 2015-08-14 22:44:24]

https://codereview.chromium.org/1293813005/diff/40001/chrome/browser/task_man...
File chrome/browser/task_manager/task_manager_browsertest_util.h (right):

https://codereview.chromium.org/1293813005/diff/40001/chrome/browser/task_man...
chrome/browser/task_manager/task_manager_browsertest_util.h:14: // use of the
old implementation and revert back to the old one.
the first "old" is suppose to be new, right?

[Lei Zhang, 2015-08-14 22:44:53]

++lgtm

[afakhry, 2015-08-14 23:04:40]

https://codereview.chromium.org/1293813005/diff/40001/chrome/browser/task_man...
File chrome/browser/task_manager/task_manager_browsertest_util.h (right):

https://codereview.chromium.org/1293813005/diff/40001/chrome/browser/task_man...
chrome/browser/task_manager/task_manager_browsertest_util.h:14: // use of the
old implementation and revert back to the old one.
On 2015/08/14 22:44:24, Lei Zhang wrote:
> the first "old" is suppose to be new, right?

Actually it's the second "old". Done.

[afakhry, 2015-08-14 23:15:53]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2015-08-14 23:15:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1293813005/#ps60001
(title: "Fix comment")

[commit-bot: I haz the power, 2015-08-14 23:16:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293813005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293813005/60001

[Lei Zhang, 2015-08-14 23:22:58]

https://codereview.chromium.org/1293813005/diff/40001/chrome/browser/task_man...
File chrome/browser/task_manager/task_manager_browsertest_util.h (right):

https://codereview.chromium.org/1293813005/diff/40001/chrome/browser/task_man...
chrome/browser/task_manager/task_manager_browsertest_util.h:14: // use of the
old implementation and revert back to the old one.
On 2015/08/14 23:04:40, afakhry wrote:
> On 2015/08/14 22:44:24, Lei Zhang wrote:
> > the first "old" is suppose to be new, right?
> 
> Actually it's the second "old". Done.

Eh? Surely you also meant the first one since that's the one you changed. :-P

[afakhry, 2015-08-14 23:25:51]

https://codereview.chromium.org/1293813005/diff/40001/chrome/browser/task_man...
File chrome/browser/task_manager/task_manager_browsertest_util.h (right):

https://codereview.chromium.org/1293813005/diff/40001/chrome/browser/task_man...
chrome/browser/task_manager/task_manager_browsertest_util.h:14: // use of the
old implementation and revert back to the old one.
On 2015/08/14 23:22:58, Lei Zhang wrote:
> On 2015/08/14 23:04:40, afakhry wrote:
> > On 2015/08/14 22:44:24, Lei Zhang wrote:
> > > the first "old" is suppose to be new, right?
> > 
> > Actually it's the second "old". Done.
> 
> Eh? Surely you also meant the first one since that's the one you changed. :-P

There used to be three "old"s in the comment! :D I guess you were talking about
the line and I was talking about the whole comment! :)

[commit-bot: I haz the power, 2015-08-15 03:01:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-15 03:01:52]

Patchset 4 (id:??) landed as
https://crrev.com/35c987ef7b7ea54d1e1b0f5139c6878fbf8c0bd8
Cr-Commit-Position: refs/heads/master@{#343558}