Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 12938016: Use a sysroot for Chrome Linux official builds. (Closed)

Created:
7 years, 9 months ago by Lei Zhang
Modified:
7 years, 7 months ago
Reviewers:
Michael Moss, mmoss
CC:
chromium-reviews, Michael Moss
Visibility:
Public.

Description

Use a sysroot for Chrome Linux official builds. BUG=224487 R=mmoss@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198637

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : #

Patch Set 5 : add hooks, exclude lucid builders #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -3 lines) Patch
M DEPS View 1 2 3 4 2 chunks +48 lines, -0 lines 0 comments Download
M build/common.gypi View 1 2 3 4 5 chunks +25 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
7 years, 7 months ago (2013-05-04 03:16:31 UTC) #1
mmoss
lgtm
7 years, 7 months ago (2013-05-06 17:28:36 UTC) #2
Lei Zhang
Committed patchset #5 manually as r198637 (presubmit successful).
7 years, 7 months ago (2013-05-07 05:36:10 UTC) #3
Lei Zhang
On 2013/05/07 05:36:10, Lei Zhang wrote: > Committed patchset #5 manually as r198637 (presubmit successful). ...
7 years, 7 months ago (2013-05-07 06:02:05 UTC) #4
Lei Zhang
7 years, 7 months ago (2013-05-07 06:03:43 UTC) #5
Message was sent while issue was closed.
Alternatively, have a script in src/build/linux that checks for the existence of
the script in src-internal and call that?

Powered by Google App Engine
This is Rietveld 408576698