Issue 12938013: Remove dead method WebContents::ShouldAcceptDragAndDrop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12938013: Remove dead method WebContents::ShouldAcceptDragAndDrop (Closed)

Created:
7 years, 9 months ago by dcheng

Modified:
7 years, 9 months ago

Reviewers:
jam, Jói

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, xiyuan, zel

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove dead method WebContents::ShouldAcceptDragAndDrop This method is no longer used. It was originally intended to prevent drag and drop operations on popup windows and panels on CrOS from triggering navigation operations in a new tab. Unfortunately, this is not the correct way to fix the problem anyway; if this method were actually used, it would prevent *all* drag and drop from working in the popup/panel window. The correct fix is to plumb through the relevant drag and drop policy to WebKit so the renderer knows not to initiate a navigation. BUG=none TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190045

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -16 lines)			Patch
M	content/browser/web_contents/web_contents_impl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	content/public/browser/web_contents.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jói

LGTM, but note you will need to TBR to someone from content/browser/OWNERS or content/OWNERS as ...

7 years, 9 months ago (2013-03-23 08:39:24 UTC) #2

dcheng

7 years, 9 months ago (2013-03-23 17:44:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r190045 (presubmit successful).

Expand Messages | Collapse Messages