Issue 12938005: Work around MSAA/lines issue on Linux bot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12938005: Work around MSAA/lines issue on Linux bot. (Closed)

Created:
7 years, 9 months ago by bsalomon

Modified:
7 years, 9 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Work around MSAA/lines issue on Linux bot. Committed: https://code.google.com/p/skia/source/detail?r=8239

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	src/gpu/gl/GrGpuGL.cpp	View		3 chunks	+10 lines, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + comment suggestion https://codereview.chromium.org/12938005/diff/1/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): https://codereview.chromium.org/12938005/diff/1/src/gpu/gl/GrGpuGL.cpp#newcode1938 src/gpu/gl/GrGpuGL.cpp:1938: // the target is not ...

7 years, 9 months ago (2013-03-19 18:56:05 UTC) #2

bsalomon

https://codereview.chromium.org/12938005/diff/1/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): https://codereview.chromium.org/12938005/diff/1/src/gpu/gl/GrGpuGL.cpp#newcode1938 src/gpu/gl/GrGpuGL.cpp:1938: // the target is not multisampled. Single pixel wide ...

7 years, 9 months ago (2013-03-19 18:56:46 UTC) #3

bsalomon

7 years, 9 months ago (2013-03-19 18:58:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r8239 (presubmit successful).

Expand Messages | Collapse Messages