Issue 12938004: Use function-ptr instead of SkFontHost api to allow client to handle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12938004: Use function-ptr instead of SkFontHost api to allow client to handle (Closed)

Created:
7 years, 9 months ago by reed1

Modified:
7 years, 9 months ago

Reviewers:
bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Use function-ptr instead of SkFontHost api to allow client to handle loading GDI font data for fonts. Committed: https://code.google.com/p/skia/source/detail?r=8301

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -37 lines)			Patch
M	gyp/ports.gyp	View	1 2 3 4	1 chunk	+0 lines, -1 line	0 comments	Download
D	src/ports/SkFontHost_sandbox_none.cpp	View	1 2 3 4	1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/ports/SkFontHost_win.cpp	View	1 2 3 4	15 chunks	+32 lines, -22 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

reed1

staging this seems tricky, so I was hoping I can just submit the chrome patch ...

7 years, 9 months ago (2013-03-19 17:49:21 UTC) #1

bungeman-skia

On 2013/03/19 17:49:21, reed1 wrote: > staging this seems tricky, so I was hoping I ...

7 years, 9 months ago (2013-03-19 18:19:08 UTC) #2

reed1

7 years, 9 months ago (2013-03-21 18:39:31 UTC) #4

chrome now calls our setter.

for this CL, I reverted the removal from SkFontHost.h. This change has the
effect of 
- respecting chrome's call of our setter
- ignoring chrome's impl of SkFontHost::EnsureTypefaceAvailable

Next CL is to remove chrome's orphaned impl of SkFontHost::Ensure...

Next next CL is to remove Ensure from SkFontHost.h

Expand Messages | Collapse Messages