Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1293793010: Remove test for packages with ':' in the name. (Closed)

Created:
5 years, 4 months ago by Harry Terkelsen
Modified:
5 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove test for packages with ':' in the name. Windows does not allow paths with ':'. If we include a directory named 'qu:ux' in the repo then it cannot even be cloned on a Windows machine. BUG= R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/7a219da572ac6813a4c98a019b51688bf06fd379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
D tests/standalone/package/scenarios/packages_file_strange_formatting/qu:ux/quux.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D tests/standalone/package/scenarios/packages_file_strange_formatting/target_with_colon.packages View 1 chunk +0 lines, -2 lines 0 comments Download
D tests/standalone/package/scenarios/packages_file_strange_formatting/target_with_colon_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Harry Terkelsen
5 years, 4 months ago (2015-08-20 00:32:37 UTC) #2
Ivan Posva
LGTM -ip
5 years, 4 months ago (2015-08-20 00:52:44 UTC) #3
Harry Terkelsen
5 years, 4 months ago (2015-08-20 00:53:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7a219da572ac6813a4c98a019b51688bf06fd379 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698