Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1293793004: Devtools: Update Mac shortcut symbols usability (Closed)

Created:
5 years, 4 months ago by samli
Modified:
5 years, 4 months ago
Reviewers:
paulirish, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Update Mac shortcut symbols usability Option and control keys are explicit instead of using the symbols. Command appears first always. BUG=521207 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200794

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/devtools/front_end/ui/KeyboardShortcut.js View 1 2 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
samli
Screenshot: http://i.imgur.com/pY7Q0vq.png
5 years, 4 months ago (2015-08-17 01:16:00 UTC) #2
paulirish
this is infinitely more useful. thx. lgtm
5 years, 4 months ago (2015-08-17 01:51:45 UTC) #3
pfeldman
On 2015/08/17 01:51:45, paulirish wrote: > this is infinitely more useful. thx. > lgtm - ...
5 years, 4 months ago (2015-08-17 18:55:25 UTC) #4
paulirish
> - lets not render "+" as a part of the shortcut > - lets ...
5 years, 4 months ago (2015-08-17 19:07:19 UTC) #5
samli
Done. http://i.imgur.com/kXGFKYr.png I think the (opt) looks a tad strange.
5 years, 4 months ago (2015-08-18 01:35:02 UTC) #6
pfeldman
fine with s/(opt)/opt/ lgtm
5 years, 4 months ago (2015-08-18 18:36:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293793004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293793004/40001
5 years, 4 months ago (2015-08-19 03:23:07 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 04:36:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200794

Powered by Google App Engine
This is Rietveld 408576698