Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: runtime/lib/typeddata.dart

Issue 12937010: Handle TypedDataView objects in Dart_TypedDataAcquireData and (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/typeddata.dart
===================================================================
--- runtime/lib/typeddata.dart (revision 20452)
+++ runtime/lib/typeddata.dart (working copy)
@@ -1982,7 +1982,7 @@
String message = "$index must be in the range [0..$length)";
throw new RangeError(message);
}
- _typeddata. setInt8(offsetInBytes + (index * Int8List.BYTES_PER_ELEMENT),
+ _typeddata._setInt8(offsetInBytes + (index * Int8List.BYTES_PER_ELEMENT),
_toInt8(value));
}
@@ -2464,8 +2464,8 @@
_ByteDataView(ByteBuffer _buffer, int _offsetInBytes, int _lengthInBytes)
: _typeddata = _buffer as TypedData,
_offset = _offsetInBytes,
- _length = _lengthInBytes {
- _rangeCheck(_buffer.lengthInBytes, _offset, _length);
+ length = _lengthInBytes {
+ _rangeCheck(_buffer.lengthInBytes, _offset, length);
}
@@ -2476,10 +2476,10 @@
}
int get lengthInBytes {
- return _length;
+ return length;
}
- int offsetInBytes() {
+ int get offsetInBytes {
return _offset;
}
@@ -2557,7 +2557,7 @@
final TypedData _typeddata;
final int _offset;
- final int _length;
+ final int length;
}
« no previous file with comments | « no previous file | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698