Handle TypedDataView objects in Dart_TypedDataAcquireData and

runtime/vm/raw_object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/raw_object.h"
 
 #include "vm/class_table.h"
 #include "vm/freelist.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
@@ skipping 275 matching lines @@
 intptr_t RawObject::VisitPointers(ObjectPointerVisitor* visitor) {
   intptr_t size = 0;
   NoHandleScope no_handles(visitor->isolate());
 
   // Only reasonable to be called on heap objects.
   ASSERT(IsHeapObject());
 
   // Read the necessary data out of the class before visting the class itself.
   intptr_t class_id = GetClassId();
 
-  if (class_id < kNumPredefinedCids) {
+  if (class_id < kNumPredefinedCids &&
+      !RawObject::IsTypedDataViewClassId(class_id)) {

[Ivan Posva, 2013/03/22 04:50:01]

We should not add an extra test into this time critical code. Either we need to
have these values in such a way that it is a simple test or we define this typed
data view within the VM.

[siva, 2013/03/25 17:20:35]

I have removed this extra check and instead moved the code for typed data view
classes into the switch statement.


On 2013/03/22 04:50:01, Ivan Posva wrote:

     switch (class_id) {
 #define RAW_VISITPOINTERS(clazz)                                               \
       case clazz::kClassId: {                                                  \
         Raw##clazz* raw_obj = reinterpret_cast<Raw##clazz*>(this);             \
         size = Raw##clazz::Visit##clazz##Pointers(raw_obj, visitor);           \
         break;                                                                 \
       }
       CLASS_LIST_NO_OBJECT(RAW_VISITPOINTERS)
 #undef RAW_VISITPOINTERS
 #define RAW_VISITPOINTERS(clazz)                                               \
@@ skipping 806 matching lines @@
 
 intptr_t RawWeakProperty::VisitWeakPropertyPointers(
     RawWeakProperty* raw_obj, ObjectPointerVisitor* visitor) {
   // Make sure that we got here with the tagged pointer as this.
   ASSERT(raw_obj->IsHeapObject());
   visitor->VisitPointers(raw_obj->from(), raw_obj->to());
   return WeakProperty::InstanceSize();
 }
 
 }  // namespace dart