Handle TypedDataView objects in Dart_TypedDataAcquireData and

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
@@ skipping 897 matching lines @@
       Array::Handle(Array::New(RawObject::NumberOfTypedDataClasses()));
   int index = 0;
 #define REGISTER_TYPED_DATA_CLASS(clazz)                                       \
   cls = Class::NewTypedDataClass(kTypedData##clazz##Cid);                      \
   index = kTypedData##clazz##Cid - kTypedDataInt8ArrayCid;                     \
   typeddata_classes.SetAt(index, cls);                                         \
   RegisterPrivateClass(cls, Symbols::_##clazz(), lib);                         \
 
   CLASS_LIST_TYPED_DATA(REGISTER_TYPED_DATA_CLASS);
 #undef REGISTER_TYPED_DATA_CLASS
+#define REGISTER_TYPED_DATA_VIEW_CLASS(clazz)                                  \
+  cls = Class::NewTypedDataViewClass(kTypedData##clazz##ViewCid);              \
+  index = kTypedData##clazz##ViewCid - kTypedDataInt8ArrayCid;                 \
+  typeddata_classes.SetAt(index, cls);                                         \
+  RegisterPrivateClass(cls, Symbols::_##clazz##View(), lib);                   \
+  pending_classes.Add(cls, Heap::kOld);                                        \
+
+  CLASS_LIST_TYPED_DATA(REGISTER_TYPED_DATA_VIEW_CLASS);
+#undef REGISTER_TYPED_DATA_VIEW_CLASS
 #define REGISTER_EXT_TYPED_DATA_CLASS(clazz)                                   \
   cls = Class::NewExternalTypedDataClass(kExternalTypedData##clazz##Cid);      \
   index = kExternalTypedData##clazz##Cid - kTypedDataInt8ArrayCid;             \
   typeddata_classes.SetAt(index, cls);                                         \
   RegisterPrivateClass(cls, Symbols::_External##clazz(), lib);                 \
 
   CLASS_LIST_TYPED_DATA(REGISTER_EXT_TYPED_DATA_CLASS);
 #undef REGISTER_EXT_TYPED_DATA_CLASS
   object_store->set_typeddata_classes(typeddata_classes);
 
@@ skipping 140 matching lines @@
   cls = Class::New<ImmutableArray>();
   object_store->set_immutable_array_class(cls);
 
   cls = Class::New<GrowableObjectArray>();
   object_store->set_growable_object_array_class(cls);
 
 #define REGISTER_SCALARLIST_CLASS(name, object_store_name)                     \
   cls = Class::New<name>();                                                    \
   object_store->set_##object_store_name##_class(cls);                          \
 
   REGISTER_SCALARLIST_CLASS(Float32x4, float32x4);

[Ivan Posva, 2013/03/22 04:50:01]

Can we make it a goal to remove dart:scalarlist on Monday?

[siva, 2013/03/25 17:20:35]

Yes, once the simd stuff has landed we could get rid of it.

On 2013/03/22 04:50:01, Ivan Posva wrote:

   REGISTER_SCALARLIST_CLASS(Uint32x4, uint32x4);
   REGISTER_SCALARLIST_CLASS(Int8Array, int8_array);
   REGISTER_SCALARLIST_CLASS(Uint8Array, uint8_array);
   REGISTER_SCALARLIST_CLASS(Uint8ClampedArray, uint8_clamped_array);
   REGISTER_SCALARLIST_CLASS(Int16Array, int16_array);
   REGISTER_SCALARLIST_CLASS(Uint16Array, uint16_array);
   REGISTER_SCALARLIST_CLASS(Int32Array, int32_array);
   REGISTER_SCALARLIST_CLASS(Uint32Array, uint32_array);
   REGISTER_SCALARLIST_CLASS(Int64Array, int64_array);
   REGISTER_SCALARLIST_CLASS(Uint64Array, uint64_array);
@@ skipping 12 matching lines @@
   REGISTER_SCALARLIST_CLASS(ExternalUint64Array, external_uint64_array);
   REGISTER_SCALARLIST_CLASS(ExternalFloat32x4Array, external_float32x4_array);
   REGISTER_SCALARLIST_CLASS(ExternalFloat32Array, external_float32_array);
   REGISTER_SCALARLIST_CLASS(ExternalFloat64Array, external_float64_array);
 #undef REGISTER_SCALARLIST_CLASS
 
 #define REGISTER_TYPED_DATA_CLASS(clazz)                                       \
   cls = Class::NewTypedDataClass(kTypedData##clazz##Cid);
   CLASS_LIST_TYPED_DATA(REGISTER_TYPED_DATA_CLASS);
 #undef REGISTER_TYPED_DATA_CLASS
+#define REGISTER_TYPED_DATA_VIEW_CLASS(clazz)                                  \
+  cls = Class::NewTypedDataViewClass(kTypedData##clazz##ViewCid);
+  CLASS_LIST_TYPED_DATA(REGISTER_TYPED_DATA_VIEW_CLASS);
+#undef REGISTER_TYPED_DATA_VIEW_CLASS
 #define REGISTER_EXT_TYPED_DATA_CLASS(clazz)                                   \
   cls = Class::NewExternalTypedDataClass(kExternalTypedData##clazz##Cid);
   CLASS_LIST_TYPED_DATA(REGISTER_EXT_TYPED_DATA_CLASS);
 #undef REGISTER_EXT_TYPED_DATA_CLASS
 
   cls = Class::New<Integer>();
   object_store->set_integer_implementation_class(cls);
 
   cls = Class::New<Smi>();
   object_store->set_smi_class(cls);
@@ skipping 824 matching lines @@
   ASSERT(RawObject::IsTypedDataClassId(class_id));
   intptr_t instance_size = TypedData::InstanceSize();
   Class& result = Class::Handle(New<TypedData>(class_id));
   result.set_instance_size(instance_size);
   result.set_next_field_offset(instance_size);
   result.set_is_prefinalized();
   return result.raw();
 }
 
 
+RawClass* Class::NewTypedDataViewClass(intptr_t class_id) {
+  ASSERT(RawObject::IsTypedDataViewClassId(class_id));
+  Class& result = Class::Handle(New<Instance>(class_id));
+  result.set_instance_size(0);
+  result.set_next_field_offset(0);
+  return result.raw();
+}
+
+
 RawClass* Class::NewExternalTypedDataClass(intptr_t class_id) {
   ASSERT(RawObject::IsExternalTypedDataClassId(class_id));
   intptr_t instance_size = ExternalTypedData::InstanceSize();
   Class& result = Class::Handle(New<ExternalTypedData>(class_id));
   result.set_instance_size(instance_size);
   result.set_next_field_offset(instance_size);
   result.set_is_prefinalized();
   return result.raw();
 }
 
@@ skipping 11653 matching lines @@
   }
   return result.raw();
 }
 
 
 const char* WeakProperty::ToCString() const {
   return "_WeakProperty";
 }
 
 }  // namespace dart