Handle TypedDataView objects in Dart_TypedDataAcquireData and

runtime/vm/dart_api_impl_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/json.h"
 #include "platform/utils.h"
 #include "vm/class_finalizer.h"
 #include "vm/dart_api_impl.h"
@@ skipping 903 matching lines @@
                        " to be non-null.");
   result = Dart_TypedDataReleaseData(str);
   EXPECT_ERROR(result, "Dart_TypedDataReleaseData expects argument 'object'"
                        " to be of type 'TypedData'.");
 }
 
 
 static void TestDirectAccess(Dart_Handle lib,
                              Dart_Handle array,
                              Dart_TypedData_Type expected_type) {
+  Dart_Handle result;
+
   // Invoke the dart function that sets initial values.
   Dart_Handle dart_args[1];
   dart_args[0] = array;
-  Dart_Invoke(lib, NewString("setMain"), 1, dart_args);
+  result = Dart_Invoke(lib, NewString("setMain"), 1, dart_args);
+  EXPECT_VALID(result);
 
   // Now Get a direct access to this typed data object and check it's contents.
   const int kLength = 10;
-  Dart_Handle result;
   Dart_TypedData_Type type;
   void* data;
   intptr_t len;
   result = Dart_TypedDataAcquireData(array, &type, &data, &len);
   EXPECT_VALID(result);
   EXPECT_EQ(expected_type, type);
   EXPECT_EQ(kLength, len);
   int8_t* dataP = reinterpret_cast<int8_t*>(data);
   for (int i = 0; i < kLength; i++) {
     EXPECT_EQ(i, dataP[i]);
   }
 
   // Now modify the values in the directly accessible array and then check
   // it we see the changes back in dart.
   for (int i = 0; i < kLength; i++) {
     dataP[i] += 10;
   }
 
   // Release direct accesss to the typed data object.
   result = Dart_TypedDataReleaseData(array);
   EXPECT_VALID(result);
 
   // Invoke the dart function in order to check the modified values.
-  Dart_Invoke(lib, NewString("testMain"), 1, dart_args);
+  result = Dart_Invoke(lib, NewString("testMain"), 1, dart_args);
+  EXPECT_VALID(result);
 }
 
 
 TEST_CASE(TypedDataDirectAccess1) {
   const char* kScriptChars =
       "import 'dart:typeddata';\n"
       "void setMain(var a) {"
       "  for (var i = 0; i < 10; i++) {"
       "    a[i] = i;"
       "  }"
       "}\n"
-      "void testMain(var list) {"
+      "bool testMain(var list) {"
       "  for (var i = 0; i < 10; i++) {"
       "    Expect.equals((10 + i), list[i]);"
       "  }\n"
+      "  return true;"
       "}\n"
       "List main() {"
       "  var a = new Int8List(10);"
       "  return a;"
       "}\n";
   // Create a test library and Load up a test script in it.
   Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
 
   // Test with an regular typed data object.
   Dart_Handle list_access_test_obj;
   list_access_test_obj = Dart_Invoke(lib, NewString("main"), 0, NULL);
   EXPECT_VALID(list_access_test_obj);
   TestDirectAccess(lib, list_access_test_obj, kInt8);
 
   // Test with an external typed data object.
   uint8_t data[] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 };
   intptr_t data_length = ARRAY_SIZE(data);
   Dart_Handle ext_list_access_test_obj;
   ext_list_access_test_obj = Dart_NewExternalTypedData(kUint8,
                                                        data,
                                                        data_length,
                                                        NULL, NULL);
   EXPECT_VALID(ext_list_access_test_obj);
   TestDirectAccess(lib, ext_list_access_test_obj, kUint8);
 }
 
 
+TEST_CASE(TypedDataViewDirectAccess) {
+  const char* kScriptChars =
+      "import 'dart:typeddata';\n"
+      "void setMain(var list) {"
+      "  Expect.equals(10, list.length);"
+      "  for (var i = 0; i < 10; i++) {"
+      "    list[i] = i;"
+      "  }"
+      "}\n"
+      "bool testMain(var list) {"
+      "  Expect.equals(10, list.length);"
+      "  for (var i = 0; i < 10; i++) {"
+      "    Expect.equals((10 + i), list[i]);"
+      "  }"
+      "  return true;"
+      "}\n"
+      "List main() {"
+      "  var a = new Int8List(100);"
+      "  var view = new Int8List.view(a.buffer, 50, 10);"
+      "  return view;"
+      "}\n";
+  // Create a test library and Load up a test script in it.
+  Dart_Handle lib = TestCase::LoadTestScript(kScriptChars, NULL);
+
+  // Test with a typed data view object.
+  Dart_Handle list_access_test_obj;
+  list_access_test_obj = Dart_Invoke(lib, NewString("main"), 0, NULL);
+  EXPECT_VALID(list_access_test_obj);
+  TestDirectAccess(lib, list_access_test_obj, kInt8);
+}
+
+
 static void ExternalTypedDataAccessTests(Dart_Handle obj,
                                          Dart_TypedData_Type expected_type,
                                          uint8_t data[],
                                          intptr_t data_length) {
   EXPECT_VALID(obj);
   EXPECT_EQ(expected_type, Dart_GetTypeOfExternalTypedData(obj));
   EXPECT(Dart_IsList(obj));
 
   void* raw_data = NULL;
   intptr_t len;
@@ skipping 6421 matching lines @@
                                    NULL);
   int64_t value = 0;
   result = Dart_IntegerToInt64(result, &value);
   EXPECT_VALID(result);
   EXPECT_EQ(260, value);
 }
 
 #endif  // defined(TARGET_ARCH_IA32) || defined(TARGET_ARCH_X64).
 
 }  // namespace dart