Add more instrumentation for Code::CopyFrom crasher.

Add more instrumentation for Code::CopyFrom crasher.

R=jkummerow@chromium.org
BUG=chromium:196330
Committed: http://code.google.com/p/v8/source/detail?r=13991

[Jakob Kummerow, 2013-03-19 16:32:05]

lgtm

https://codereview.chromium.org/12937004/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/12937004/diff/1/src/heap.cc#newcode3806
src/heap.cc:3806: // Allow self references to created code object by patching
the handle to
Let's add another check at this point.

https://codereview.chromium.org/12937004/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/12937004/diff/1/src/objects.cc#newcode8818
src/objects.cc:8818: memmove(instruction_start(), desc.buffer, desc.instr_size);
Let's add (before the memmove):
CHECK(reinterpret_cast<intptr_t>(instruction_start()) ==
reinterpret_cast<intptr_t>(this) + Code::kHeaderSize)

[Michael Starzinger, 2013-03-19 16:43:54]

Landing.

https://codereview.chromium.org/12937004/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/12937004/diff/1/src/heap.cc#newcode3806
src/heap.cc:3806: // Allow self references to created code object by patching
the handle to
On 2013/03/19 16:32:05, Jakob wrote:
> Let's add another check at this point.

Done.

https://codereview.chromium.org/12937004/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/12937004/diff/1/src/objects.cc#newcode8818
src/objects.cc:8818: memmove(instruction_start(), desc.buffer, desc.instr_size);
On 2013/03/19 16:32:05, Jakob wrote:
> Let's add (before the memmove):
> CHECK(reinterpret_cast<intptr_t>(instruction_start()) ==
> reinterpret_cast<intptr_t>(this) + Code::kHeaderSize)

Done.

[Michael Starzinger, 2013-03-19 16:48:54]

Committed patchset #2 manually as r13991 (presubmit successful).