Adding ElementsAccessor::Splice

- remove the Backing-Store specific code from builtins.cc and put it in elements.cc.
- adding tests to improve coverage of the splice method

BUG=

Committed: https://crrev.com/8533d4b5433d3a9e9fb1015f206997bd6d869fe3
Cr-Commit-Position: refs/heads/master@{#30269}

Committed: https://crrev.com/07a4a6cb8e2ab940b28a7151a925c796da023524
Cr-Commit-Position: refs/heads/master@{#30326}

[Camillo Bruni, 2015-08-19 08:29:22]

cbruni@chromium.org changed reviewers:
+ mvstanton@chromium.org

[mvstanton, 2015-08-20 10:45:33]

Nice test coverage, too!

LGTM.

https://codereview.chromium.org/1293683005/diff/100001/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1293683005/diff/100001/src/builtins.cc#newcod...
src/builtins.cc:180: bool ClampedToInteger(Object* object, int* out) {
I like this method much better, thanks for addressing!

[Camillo Bruni, 2015-08-20 12:27:17]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2015-08-20 12:27:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293683005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293683005/100001

[commit-bot: I haz the power, 2015-08-20 12:54:45]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-08-20 12:55:15]

Patchset 6 (id:??) landed as
https://crrev.com/8533d4b5433d3a9e9fb1015f206997bd6d869fe3
Cr-Commit-Position: refs/heads/master@{#30269}

[Camillo Bruni, 2015-08-20 13:50:30]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1305763002/ by cbruni@chromium.org.

The reason for reverting is: failing bot
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s....

[Camillo Bruni, 2015-08-21 14:03:10]

On 2015/08/20 at 13:50:30, cbruni wrote:
> A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1305763002/ by cbruni@chromium.org.
> 
> The reason for reverting is: failing bot
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s....

Cannot reproduce this locally.

[Camillo Bruni, 2015-08-24 06:47:22]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2015-08-24 06:47:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293683005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293683005/100001

[Camillo Bruni, 2015-08-24 06:54:01]

The CQ bit was unchecked by cbruni@chromium.org

[Camillo Bruni, 2015-08-24 07:50:52]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2015-08-24 07:50:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/1293683005/#ps120001
(title: "speeding up array-native-elements splice test")

[commit-bot: I haz the power, 2015-08-24 07:51:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293683005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293683005/120001

[commit-bot: I haz the power, 2015-08-24 07:59:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-24 07:59:54]

Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/8970)

[Camillo Bruni, 2015-08-24 10:26:08]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-24 10:26:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293683005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293683005/140001

[commit-bot: I haz the power, 2015-08-24 10:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-24 10:50:43]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2015-08-24 10:53:36]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2015-08-24 10:53:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/1293683005/#ps140001
(title: "uncommenting failing elements-kind checks")

[commit-bot: I haz the power, 2015-08-24 10:53:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293683005/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293683005/140001

[commit-bot: I haz the power, 2015-08-24 10:55:12]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-08-24 10:55:19]

Patchset 8 (id:??) landed as
https://crrev.com/07a4a6cb8e2ab940b28a7151a925c796da023524
Cr-Commit-Position: refs/heads/master@{#30326}

[Michael Hablich, 2015-08-25 09:51:12]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1315823004/ by hablich@chromium.org.

The reason for reverting is: Fails layout tests:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2032/buil....

[Camillo Bruni, 2015-08-25 10:46:43]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/1313893002/ by cbruni@chromium.org.

The reason for reverting is: revert 1293683005 in order to revert
https://codereview.chromium.org/1315823004.

[Camillo Bruni, 2015-08-27 09:56:49]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-27 09:57:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1293683005/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1293683005/240001

[commit-bot: I haz the power, 2015-08-27 10:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-27 10:28:01]

Dry run: This issue passed the CQ dry run.