Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1293683003: Move DocumentMarker related files to editing/markers/ from dom/ (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, dshwang, eae+blinkwatch, fs, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, krit, szager+layoutwatch_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, blink-reviews-paint_chromium.org, gyuyoung2, rwlbuis, zoltan1, sof, blink-reviews-rendering, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, f(malita), groby+blinkspell_chromium.org, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move DocumentMarker related files to editing/markers from dom/ This patch moves DocumentMarker related files from "dom/" into "editing/markers/" - DocumentMarker.{cpp,h} - DocumentMarkerController.{cpp,h} - DocumentMarkerControllerTest.cpp - RenderedDocumentMarker.h to make better modularity for improving code helath, because |DocumentMarker| and |DocumentMarkerIterator| are used editing and it isn't in DOM specification. BUG=50927 TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200541

Patch Set 1 : 2015-08-14T15:39:22 #

Total comments: 2

Patch Set 2 : 2015-08-14T16:55:17 editing/markers #

Patch Set 3 : 2015-08-14T22:49:39 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1515 lines) Patch
M Source/core/core.gypi View 1 2 4 chunks +6 lines, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
D Source/core/dom/DocumentMarker.h View 1 chunk +0 lines, -157 lines 0 comments Download
D Source/core/dom/DocumentMarker.cpp View 1 chunk +0 lines, -156 lines 0 comments Download
D Source/core/dom/DocumentMarkerController.h View 1 chunk +0 lines, -121 lines 0 comments Download
D Source/core/dom/DocumentMarkerController.cpp View 1 chunk +0 lines, -743 lines 0 comments Download
D Source/core/dom/DocumentMarkerControllerTest.cpp View 1 chunk +0 lines, -220 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/dom/RenderedDocumentMarker.h View 1 1 chunk +0 lines, -79 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.h View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/SelectionController.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SpellCheckRequester.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SpellChecker.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SpellChecker.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/SplitTextNodeCommand.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/TextCheckingHelper.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/markers/DocumentMarker.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/editing/markers/DocumentMarker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/markers/DocumentMarkerController.h View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/editing/markers/DocumentMarkerController.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/editing/markers/DocumentMarkerControllerTest.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/editing/markers/RenderedDocumentMarker.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/HitTestResult.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/svg/line/SVGInlineTextBox.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/Page.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/FramePainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/InlineTextBoxPainter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/SpellCheckerClientImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/TextFinder.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (11 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-14 07:06:25 UTC) #2
tkent
lgtm as is. https://codereview.chromium.org/1293683003/diff/1/Source/core/dom/RenderedDocumentMarker.h File Source/core/dom/RenderedDocumentMarker.h (right): https://codereview.chromium.org/1293683003/diff/1/Source/core/dom/RenderedDocumentMarker.h#newcode1 Source/core/dom/RenderedDocumentMarker.h:1: /* Do you move RenderedDocumentMarker to ...
5 years, 4 months ago (2015-08-14 07:14:19 UTC) #3
yosin_UTC9
PTAL https://codereview.chromium.org/1293683003/diff/1/Source/core/dom/RenderedDocumentMarker.h File Source/core/dom/RenderedDocumentMarker.h (right): https://codereview.chromium.org/1293683003/diff/1/Source/core/dom/RenderedDocumentMarker.h#newcode1 Source/core/dom/RenderedDocumentMarker.h:1: /* On 2015/08/14 07:14:19, tkent wrote: > Do ...
5 years, 4 months ago (2015-08-14 08:08:04 UTC) #4
tkent
lgtm
5 years, 4 months ago (2015-08-14 08:38:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293683003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293683003/20001
5 years, 4 months ago (2015-08-14 08:43:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93201)
5 years, 4 months ago (2015-08-14 09:58:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293683003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293683003/20001
5 years, 4 months ago (2015-08-14 12:07:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/88226)
5 years, 4 months ago (2015-08-14 12:12:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293683003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293683003/20001
5 years, 4 months ago (2015-08-14 13:24:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293683003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293683003/40001
5 years, 4 months ago (2015-08-14 13:51:17 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293683003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293683003/40001
5 years, 4 months ago (2015-08-14 14:01:14 UTC) #22
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 15:02:26 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200541

Powered by Google App Engine
This is Rietveld 408576698