extensions/renderer/script_context_set_unittest.cc - Issue 1293673002: Create thread-safe RendererExtensionRegistry from ExtensionSet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_context_set_unittest.cc

Issue 1293673002: Create thread-safe RendererExtensionRegistry from ExtensionSet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/script_context_set_unittest.cc

diff --git a/extensions/renderer/script_context_set_unittest.cc b/extensions/renderer/script_context_set_unittest.cc

index ea9d0013fda8e23b09660d16a3e9ea210eafd3ce..756c94290f5fbae105d32f9b0f36cb947f05c9ac 100644

--- a/extensions/renderer/script_context_set_unittest.cc

+++ b/extensions/renderer/script_context_set_unittest.cc

@@ -33,9 +33,8 @@ TEST(ScriptContextSetTest, Lifecycle) {

gin::ContextHolder context_holder(isolate);

context_holder.SetContext(v8_context);

- ExtensionSet extensions;

ExtensionIdSet active_extensions;

- ScriptContextSet context_set(&extensions, &active_extensions);

+ ScriptContextSet context_set(&active_extensions);

ScriptContext* context = context_set.Register(

web_frame.frame(), v8_context, 0, 0); // no extension group or world ID

« no previous file with comments | « extensions/renderer/script_context_set.cc ('k') | extensions/renderer/script_injection_manager.h » ('j') | no next file with comments »