Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1293643002: hunspell: Cleanup to fix the header include guards under google/ directory. (Closed)

Created:
5 years, 4 months ago by tfarina
Modified:
5 years, 4 months ago
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spellwatch_chromium.org, groby-ooo-7-16
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

hunspell: Cleanup to fix the header include guards under google/ directory. The header include guards should match the file path from root. These entries were found using fix-include-guards.py script found attached in http://crbug.com/435361#c7. BUG=None R=rouslan@chromium.org Committed: https://crrev.com/2278675b1e52b31a3c5ea5e2d20b2cb0c3426316 Cr-Commit-Position: refs/heads/master@{#343825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M third_party/hunspell/google/bdict.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/hunspell/google/bdict_reader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/hunspell/google/bdict_writer.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 4 months ago (2015-08-13 23:16:09 UTC) #1
please use gerrit instead
lgtm, but please change the second paragraph of the description to say: These entries were ...
5 years, 4 months ago (2015-08-13 23:19:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1293643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1293643002/1
5 years, 4 months ago (2015-08-18 00:08:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 05:24:34 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 05:25:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2278675b1e52b31a3c5ea5e2d20b2cb0c3426316
Cr-Commit-Position: refs/heads/master@{#343825}

Powered by Google App Engine
This is Rietveld 408576698