Make the default directory size returned by stat to be 4096

native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs_node.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "nacl_io/html5fs/html5_fs_node.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <ppapi/c/pp_completion_callback.h>
 #include <ppapi/c/pp_directory_entry.h>
 #include <ppapi/c/pp_errors.h>
 #include <ppapi/c/pp_file_info.h>
 #include <ppapi/c/ppb_file_io.h>
 #include <string.h>
 #include <vector>
 
 #include "nacl_io/filesystem.h"
 #include "nacl_io/getdents_helper.h"
 #include "nacl_io/html5fs/html5_fs.h"
 #include "nacl_io/kernel_handle.h"
 #include "nacl_io/osdirent.h"
 #include "nacl_io/pepper_interface.h"
 #include "sdk_util/auto_lock.h"
 
 namespace nacl_io {
 
 namespace {
 
+const int DIR_SIZE = 4096;

[Sam Clegg, 2015/08/13 21:33:48]

How about EMPTY_DIR_SIZE?

[binji, 2015/08/13 21:44:52]

Actually, Chromium style would be more like kEmptyDirSize

[zhitingzhu, 2015/08/13 22:26:00]

Done.

+
 struct OutputBuffer {
   void* data;
   int element_count;
 };
 
 void* GetOutputBuffer(void* user_data, uint32_t count, uint32_t size) {
   OutputBuffer* output = static_cast<OutputBuffer*>(user_data);
   output->element_count = count;
   if (count) {
     output->data = malloc(count * size);
@@ skipping 123 matching lines @@
       stat->st_mode |= S_IFREG;
       break;
     case PP_FILETYPE_DIRECTORY:
       stat->st_mode |= S_IFDIR;
       break;
     case PP_FILETYPE_OTHER:
     default:
       break;
   }
   stat->st_size = static_cast<off_t>(info.size);
+  // Hack the directory size
+  // In Linux, even a empty directory has size 4096
+  if (info.type == PP_FILETYPE_DIRECTORY && info.size == 0)
+    stat->st_size = DIR_SIZE;

[Sam Clegg, 2015/08/13 21:33:48]

Move this up into the existing switch statement?


I might be nice to know if info.size is always zero?

[zhitingzhu, 2015/08/13 22:26:00]

I try to look at the source code to see how the dir size get set, but could not
find a clue. But I guess it is always zero from what I see on devenv. 

   stat->st_atime = info.last_access_time;
   stat->st_mtime = info.last_modified_time;
   stat->st_ctime = info.creation_time;
 
   return 0;
 }
 
 Error Html5FsNode::Read(const HandleAttr& attr,
                         void* buf,
                         size_t count,
@@ skipping 134 matching lines @@
   fileref_resource_ = 0;
   Node::Destroy();
 }
 
 Error Html5FsNode::Fchmod(mode_t mode) {
   // html5fs does not support any kinds of permissions or mode bits.
   return 0;
 }
 
 }  // namespace nacl_io