Make the default directory size returned by stat to be 4096

native_client_sdk/src/libraries/nacl_io/html5fs/html5_fs_node.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "nacl_io/html5fs/html5_fs_node.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <ppapi/c/pp_completion_callback.h>
 #include <ppapi/c/pp_directory_entry.h>
@@ skipping 150 matching lines @@
     case PP_FILETYPE_REGULAR:
       stat->st_mode |= S_IFREG;
       break;
     case PP_FILETYPE_DIRECTORY:
       stat->st_mode |= S_IFDIR;
       break;
     case PP_FILETYPE_OTHER:
     default:
       break;
   }
   stat->st_size = static_cast<off_t>(info.size);

[Sam Clegg, 2015/08/13 19:08:33]

What does info.size mean for html5 fs?  Perhaps we should just completely ignore
it?

[zhitingzhu, 2015/08/13 20:56:36]

I am not sure about where the info comes from. But it still return correct size
for files. 

+  // Hack the directory size
+  // In Linux, even a empty directory has size 4096
+  if (info.type == PP_FILETYPE_DIRECTORY && info.size == 0)
+    stat->st_size = 4096;
   stat->st_atime = info.last_access_time;
   stat->st_mtime = info.last_modified_time;
   stat->st_ctime = info.creation_time;
 
   return 0;
 }
 
 Error Html5FsNode::Read(const HandleAttr& attr,
                         void* buf,
                         size_t count,
@@ skipping 48 matching lines @@
 }
 
 int Html5FsNode::GetType() {
   return fileio_resource_ ? S_IFREG : S_IFDIR;
 }
 
 Error Html5FsNode::GetSize(off_t* out_size) {
   *out_size = 0;
 
   if (IsaDir())
     return 0;

[Sam Clegg, 2015/08/13 19:08:33]

Won't this early return?

Can you use a define rather then 4096?

[zhitingzhu, 2015/08/13 20:56:36]

Done. It seems GetSize only relates to file. 

 
   AUTO_LOCK(node_lock_);
 
   PP_FileInfo info;
   int32_t result =
       file_io_iface_->Query(fileio_resource_, &info, PP_BlockUntilComplete());
   if (result != PP_OK)
     return PPERROR_TO_ERRNO(result);
 
   *out_size = info.size;
+  // In Linux, even a empty directory has size 4096
+  if (info.type == PP_FILETYPE_DIRECTORY && info.size == 0)
+     *out_size = 4096;
   return 0;
 }
 
 Html5FsNode::Html5FsNode(Filesystem* filesystem, PP_Resource fileref_resource)
     : Node(filesystem),
       fileref_resource_(fileref_resource),
       fileio_resource_(0) {
 }
 
 Error Html5FsNode::Init(int open_flags) {
@@ skipping 55 matching lines @@
   fileref_resource_ = 0;
   Node::Destroy();
 }
 
 Error Html5FsNode::Fchmod(mode_t mode) {
   // html5fs does not support any kinds of permissions or mode bits.
   return 0;
 }
 
 }  // namespace nacl_io